pre-commit/pre-commit-hooks
1
0
Fork 0
mirror of https://github.com/pre-commit/pre-commit-hooks.git synced 2026-04-05 03:26:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix false positives of check-executables-have-shebangs

Browse source 
check-executables-have-shebangs needs to check the actual file mode
known to Git and avoid relying only on the filesystem permissions,
because some filesystems force the executable bit on every file (e.g.
fat32 on Linux).
This commit is contained in:
Yann Leprince 2021-07-23 11:28:14 +02:00
parent d0d9883648
commit 741d95128b
1 changed files with 5 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

15
pre_commit_hooks/check_executables_have_shebangs.py
View file

@ -16,16 +16,11 @@ EXECUTABLE_VALUES = frozenset(('1', '3', '5', '7'))
def check_executables(paths: List[str]) -> int:
if sys.platform == 'win32': # pragma: win32 cover
return _check_git_filemode(paths)
else: # pragma: win32 no cover
retv = 0
for path in paths:
if not has_shebang(path):
_message(path)
retv = 1
return retv
# Even if this hook is configured to be called only on files flagged
# executable by identify, we must check the real filemode known to Git
# because some filesystems force the executable bit (e.g. fat32 under
# Linux).
return _check_git_filemode(paths)
class GitLsFile(NamedTuple):