pre-commit/pre-commit-hooks
1
0
Fork 0
mirror of https://github.com/pre-commit/pre-commit-hooks.git synced 2026-04-06 12:06:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix tests for check_executables_have_shebangs

Browse source
This commit is contained in:
Yann Leprince 2021-07-23 11:52:13 +02:00
parent 741d95128b
commit 534cc15887
1 changed files with 4 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

17
tests/check_executables_have_shebangs_test.py
View file

@ -1,19 +1,13 @@
import os import os
import sys
import pytest import pytest
from pre_commit_hooks import check_executables_have_shebangs from pre_commit_hooks import check_executables_have_shebangs
from pre_commit_hooks.check_executables_have_shebangs import has_shebang
from pre_commit_hooks.check_executables_have_shebangs import main from pre_commit_hooks.check_executables_have_shebangs import main
from pre_commit_hooks.util import cmd_output from pre_commit_hooks.util import cmd_output
skip_win32 = pytest.mark.skipif(
sys.platform == 'win32',
reason="non-git checks aren't relevant on windows",
)
@skip_win32 # pragma: win32 no cover
@pytest.mark.parametrize( @pytest.mark.parametrize(
'content', ( 'content', (
b'#!/bin/bash\nhello world\n', b'#!/bin/bash\nhello world\n',
@ -25,10 +19,9 @@ skip_win32 = pytest.mark.skipif(
def test_has_shebang(content, tmpdir): def test_has_shebang(content, tmpdir):
path = tmpdir.join('path') path = tmpdir.join('path')
path.write(content, 'wb') path.write(content, 'wb')
assert main((str(path),)) == 0 assert has_shebang(str(path))
@skip_win32 # pragma: win32 no cover
@pytest.mark.parametrize( @pytest.mark.parametrize(
'content', ( 'content', (
b'', b'',
@ -38,12 +31,10 @@ def test_has_shebang(content, tmpdir):
'☃'.encode(), '☃'.encode(),
), ),
) )
def test_bad_shebang(content, tmpdir, capsys): def test_bad_shebang(content, tmpdir):
path = tmpdir.join('path') path = tmpdir.join('path')
path.write(content, 'wb') path.write(content, 'wb')
assert main((str(path),)) == 1 assert not has_shebang(str(path))
_, stderr = capsys.readouterr()
assert stderr.startswith(f'{path}: marked executable but')
def test_check_git_filemode_passing(tmpdir): def test_check_git_filemode_passing(tmpdir):