Commit graph

193 commits

Author SHA1 Message Date
Anthony Sottile
6a725a0a52 Fix "invalid escape sequence" when running with -Werror
```
$ python3.7 -Werror
Python 3.7.0rc1 (default, Jun 16 2018, 03:32:08) 
[GCC 5.4.0 20160609] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> '# noqa(?:: (?P<codes>([A-Z][0-9]+(?:[,\s]+)?)+))?'
  File "<stdin>", line 1
SyntaxError: invalid escape sequence \s
```
2018-06-18 06:25:07 +00:00
Ian Stapleton Cordasco
d6eea404a8 Merge branch 'spelling' into 'master'
Spelling and grammar fixes

See merge request pycqa/flake8!232
2018-05-20 15:40:41 +00:00
Ville Skyttä
e520c2d936 Implement --extend-ignore
Refs #365
2018-05-16 08:50:26 +02:00
Ville Skyttä
9f74e7a4ca Spelling and grammar fixes 2018-05-13 22:19:50 +02:00
Ian Stapleton Cordasco
5221014947 Merge branch '405-nonexisting-files' into 'master'
Resolve "flake8 does not generate error when given a non-existent file on the command line"

Closes #405

See merge request pycqa/flake8!227
2018-04-15 23:33:40 +00:00
Craig Silverstein
a5573fc864 Move all uses of pool inside run_parallel().
This includes creating the pool, tearing it down under normal use, and
tearing it down in case of exception.

Doing this makes it harder to leak processes, as for instance was
happening in #410.

Fixes #410
2018-03-02 20:49:31 -08:00
Avraham Shukron
59218ca323 Report error when non-exiting path is passed to flake8 2018-02-21 18:19:59 +02:00
Ian Stapleton Cordasco
6381d86f00 Merge branch 'formatter-print-observe-newline' into 'master'
Respect a formatter's newline setting when printing

See merge request pycqa/flake8!222
2018-01-01 00:57:09 +00:00
Ian Stapleton Cordasco
0c7de6df55 Merge branch 'isort-fix' into 'master'
fix for flake8-isort

See merge request pycqa/flake8!215
2018-01-01 00:53:56 +00:00
Ian Stapleton Cordasco
49f0fbcf1e
Respect a formatter's newline setting when printing
In working on flake8-json, I noticed that setting newline was only
helpful for writing to an ouput-file but not to standard-out. It makes
sense for this setting to apply to both branches otherwise plugins need
to override the method to get the behaviour they expect.
2017-12-31 18:50:59 -06:00
Ian Stapleton Cordasco
3043115551
Implement better UX around broken plugins
This handles most any exception arising from a plugin and provides the
user with a better experience and view of the problem. It also provides
a way to retrieve the information about what exactly failed for
providing bug reports to plugin authors.
2017-12-31 18:46:59 -06:00
Tomer Chachamu
9d2ff76d31 fix for flake8-isort 2017-11-27 11:10:41 +00:00
Ian Stapleton Cordasco
3530870679 Merge branch 'local-plugin-paths' into 'master'
Add paths option in local-plugins config file.

Closes #379

See merge request pycqa/flake8!211
2017-11-26 18:40:04 +00:00
Ian Stapleton Cordasco
55caffdbe9
Stop being silly
We don't support Python 2.6 so we don't need to support this backwards
compatibility
2017-11-26 12:32:29 -06:00
Ian Stapleton Cordasco
a3a2539a23
Fix-up new I202 violations 2017-11-26 11:25:06 -06:00
Carl Meyer
dd1e9d1cb7 Use default comma-separated regex for local-plugin paths. 2017-10-25 08:57:46 -07:00
Carl Meyer
423980164b Add paths option in local-plugins config file. 2017-10-24 19:58:18 -07:00
Ian Stapleton Cordasco
8acf55e0f8
Prepare for v3.5.0 release on 2017-10-23 2017-10-21 07:25:12 -05:00
Anthony Sottile
bbe8d6d6c6 Catch UnicodeDecodeError while parsing config files 2017-10-09 09:52:37 -07:00
Ian Stapleton Cordasco
222f0a8115
Allow our local plugin parsing to accept commas
By slightly modifying our utility function to parse comma separated
lists we can parse local plugins similar to other configuration options.
2017-08-09 19:35:01 -05:00
Ian Stapleton Cordasco
156f90369f
Update our plugin registration for debugging
This allows us to report whether or not a plugin is local when users
provide `flake8 --bug-report` output.
2017-08-08 08:54:40 -05:00
Ian Stapleton Cordasco
d5dfd1180d Merge branch 'issue/362' into 'master'
Lint only *.py files with --diff option

Closes #362

See merge request !206
2017-08-08 12:40:27 +00:00
Josef Skladanka
bf25fef7eb Lint only *.py files with --diff option
When using the `--diff` option flake8 only lints *.py files or files
defined by the `--filename` filter.

Fixes #362
2017-08-08 06:27:54 +02:00
Carl Meyer
54a8a551b3 Fix finding of local config files. 2017-08-07 17:57:25 -07:00
Ian Stapleton Cordasco
3169b6072b Merge branch 'local-plugins' into 'master'
Add support for local (in-repo, non-setuptools) plugins.

Closes #357

See merge request !197
2017-08-07 11:19:30 +00:00
Ian Stapleton Cordasco
1f0e6a6ffa Merge branch 'hook_conf' into 'master'
Tell user how to configure VCS hooks

See merge request !198
2017-08-07 10:56:37 +00:00
Peter Cock
12660a6fb7 Remove trailing new line; insert raises 2017-08-07 11:39:18 +01:00
Carl Meyer
18c0b14b5c Append [local] to version of local plugins. 2017-08-06 20:57:04 -07:00
Carl Meyer
2cadc060d3 Don't load local plugins from user config. 2017-08-06 20:47:02 -07:00
Carl Meyer
f82aab5820 Minor argument changes. 2017-08-06 20:46:46 -07:00
Ian Stapleton Cordasco
778ddf3ce1
Prepare master branch for development of 3.5.0 2017-08-06 14:02:58 -05:00
Peter Cock
9457d84cfd Tell user how to configure VCS hooks.
Also fills out the hg install hook docstring.

This would close GitLab issue #335.
2017-08-04 11:47:50 +01:00
Carl Meyer
06a5e19769 Handle argv being None. 2017-08-03 11:05:33 -07:00
Carl Meyer
4e58068657 Add support for local (in-repo, non-setuptools) plugins.
Closes #357
2017-08-03 00:25:37 -07:00
Ian Stapleton Cordasco
ec996ffd85
Allow spaces in # noqa lists
To match our new configuration file format and its allowance for spaces
in the list

Closes #356
2017-07-28 19:31:32 -05:00
Ian Stapleton Cordasco
411edfa6f9
Bump version to 3.4.1 and add release notes 2017-07-28 06:15:49 -05:00
Ian Stapleton Cordasco
a44a09f87a
Remediate one wafer thing decision logic bug
Previously we were hitting the catch-all return that decided the error
was selected. Instead, let's add specific logic since we now know how we
would hit that and we actually don't want it to be selected.

Closes #354
2017-07-28 06:10:12 -05:00
Ian Stapleton Cordasco
0239f15dcc
Release v3.4.0 2017-07-27 18:57:29 -05:00
Ian Stapleton Cordasco
a0dabc1d42
Merge branch 'fix-quiet' 2017-07-27 18:44:39 -05:00
Shinya Kawaguchi
55e85b4b50
Fix quiet/verbose config problem 2017-07-27 18:44:08 -05:00
Ayman Nedjmeddine
43e2648ac3 Removed unused imported module os form flake8.main.git._HOOK_TEMPLATE 2017-07-27 10:59:49 +00:00
Ian Cordasco
ff07ca3ed9
Add some better comments for decision logic 2017-06-04 15:07:10 -05:00
Ian Cordasco
86e1fb6e64
Pull decision making out of decision_for
Also, this further highlights why naming methods is so hard. I can't
think of a better name for 'more_specific_decision_for' that isn't
wildly long and unnecessarily verbose.
2017-06-04 14:50:20 -05:00
Ian Cordasco
92c367dee4
Rename style_guide.Error to style_guide.Violation
Move all Violation related methods from the StyleGuide to our Violation
class.
2017-06-04 07:57:28 -05:00
Ian Cordasco
65107a5624
Rename methods on the new DecisionEngine
Rename `decision_for` to `more_specific_decision_for` and
`should_report_error` to `decision_for`.
2017-06-03 19:20:46 -05:00
Ian Cordasco
7fef0af0f5
Refactor decision logic into its own object
In dealing with the decision logic in the StyleGuide recently I
recognized that the logic really doesn't belong strictly on the
StyleGuide. A separate object makes perfect sense especially from the
perspective of testability. This is a minor refactor intended solely to
facilitate further testing and perhaps making the logic easier to
understand for others.
2017-06-01 20:36:37 -05:00
Ian Cordasco
feec0754bd
Add debugging utility for FileChecker 2017-06-01 20:06:34 -05:00
Ian Cordasco
fec980a856 Merge branch 'bug/318' into 'master'
Further improve our handling of --select and --ignore

Closes #318

See merge request !187
2017-05-28 01:41:13 +00:00
Ian Cordasco
aefa79535f
Simplify conditoinal in decision logic
Add test to cover branch of decision logic we were not previously
exercising
2017-05-27 20:34:04 -05:00
Ian Cordasco
2baaf00e83
Further refine our logic handling selection
There was a *very* subtle bug in how we handle blanket select statements
with error codes that are in our DEFAULT_IGNORE. In the specific case,
users were specifying ``--select E`` and E126 was not being properly
reported. This unveiled further logic bugs as we refined this.

Closes #318
2017-05-27 19:22:38 -05:00