mirror of
https://github.com/PyCQA/flake8.git
synced 2026-04-04 12:16:53 +00:00
Respect a formatter's newline setting when printing
In working on flake8-json, I noticed that setting newline was only helpful for writing to an ouput-file but not to standard-out. It makes sense for this setting to apply to both branches otherwise plugins need to override the method to get the behaviour they expect.
This commit is contained in:
parent
3530870679
commit
49f0fbcf1e
2 changed files with 5 additions and 5 deletions
|
|
@ -172,7 +172,7 @@ class BaseFormatter(object):
|
|||
if self.output_fd is not None:
|
||||
self.output_fd.write(output + self.newline)
|
||||
if self.output_fd is None or self.options.tee:
|
||||
print(output)
|
||||
print(output, end=self.newline)
|
||||
|
||||
def write(self, line, source):
|
||||
"""Write the line either to the output file or stdout.
|
||||
|
|
|
|||
|
|
@ -92,8 +92,8 @@ def test_write_uses_an_output_file(tee):
|
|||
if tee:
|
||||
assert print_func.called
|
||||
assert print_func.mock_calls == [
|
||||
mock.call(line),
|
||||
mock.call(source),
|
||||
mock.call(line, end='\n'),
|
||||
mock.call(source, end='\n'),
|
||||
]
|
||||
else:
|
||||
assert not print_func.called
|
||||
|
|
@ -118,8 +118,8 @@ def test_write_uses_print(print_function):
|
|||
assert print_function.called is True
|
||||
assert print_function.call_count == 2
|
||||
assert print_function.mock_calls == [
|
||||
mock.call(line),
|
||||
mock.call(source),
|
||||
mock.call(line, end='\n'),
|
||||
mock.call(source, end='\n'),
|
||||
]
|
||||
|
||||
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue