4
0
Fork 0
mirror of https://github.com/Azure/setup-helm.git synced 2025-11-07 21:16:57 +00:00

Edited comment on isValidVersion

This commit is contained in:
Asa Gayle 2022-01-25 16:14:23 -05:00
parent f89e61b2b4
commit 700a7c0faa
2 changed files with 6 additions and 6 deletions

View file

@ -84,8 +84,8 @@ function downloadHelm(version) {
}); });
} }
exports.downloadHelm = downloadHelm; exports.downloadHelm = downloadHelm;
// Downloads the helm release JSON and parses all the recent versions of helm from it. // Downloads the helm releases JSON and parses all the recent versions of helm from it.
// Defaults to sending stable helm version if none are valid. // Defaults to sending stable helm version if none are valid or if it fails
function getLatestHelmVersion() { function getLatestHelmVersion() {
return __awaiter(this, void 0, void 0, function* () { return __awaiter(this, void 0, void 0, function* () {
let helmJSONPath = yield toolCache.downloadTool(helmAllReleasesUrl); let helmJSONPath = yield toolCache.downloadTool(helmAllReleasesUrl);
@ -105,7 +105,7 @@ function getLatestHelmVersion() {
}); });
} }
exports.getLatestHelmVersion = getLatestHelmVersion; exports.getLatestHelmVersion = getLatestHelmVersion;
// isValidVersion checks if verison matches the specified type and is a stable release // isValidVersion checks if verison is a stable release
function isValidVersion(version) { function isValidVersion(version) {
return version.indexOf('rc') == -1; return version.indexOf('rc') == -1;
} }

View file

@ -78,8 +78,8 @@ export async function downloadHelm(version: string): Promise<string> {
return helmpath; return helmpath;
} }
// Downloads the helm release JSON and parses all the recent versions of helm from it. // Downloads the helm releases JSON and parses all the recent versions of helm from it.
// Defaults to sending stable helm version if none are valid. // Defaults to sending stable helm version if none are valid or if it fails
export async function getLatestHelmVersion(): Promise<string> { export async function getLatestHelmVersion(): Promise<string> {
let helmJSONPath:string = await toolCache.downloadTool(helmAllReleasesUrl); let helmJSONPath:string = await toolCache.downloadTool(helmAllReleasesUrl);
@ -99,7 +99,7 @@ export async function getLatestHelmVersion(): Promise<string> {
return stableHelmVersion; return stableHelmVersion;
} }
// isValidVersion checks if verison matches the specified type and is a stable release // isValidVersion checks if verison is a stable release
function isValidVersion(version: string): boolean { function isValidVersion(version: string): boolean {
return version.indexOf('rc') == -1; return version.indexOf('rc') == -1;
} }