From 700a7c0faa5151aba5efd1db14cef44012f2dd82 Mon Sep 17 00:00:00 2001 From: Asa Gayle Date: Tue, 25 Jan 2022 16:14:23 -0500 Subject: [PATCH] Edited comment on isValidVersion --- lib/run.js | 6 +++--- src/run.ts | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/run.js b/lib/run.js index eba26ab..81d398c 100644 --- a/lib/run.js +++ b/lib/run.js @@ -84,8 +84,8 @@ function downloadHelm(version) { }); } exports.downloadHelm = downloadHelm; -// Downloads the helm release JSON and parses all the recent versions of helm from it. -// Defaults to sending stable helm version if none are valid. +// Downloads the helm releases JSON and parses all the recent versions of helm from it. +// Defaults to sending stable helm version if none are valid or if it fails function getLatestHelmVersion() { return __awaiter(this, void 0, void 0, function* () { let helmJSONPath = yield toolCache.downloadTool(helmAllReleasesUrl); @@ -105,7 +105,7 @@ function getLatestHelmVersion() { }); } exports.getLatestHelmVersion = getLatestHelmVersion; -// isValidVersion checks if verison matches the specified type and is a stable release +// isValidVersion checks if verison is a stable release function isValidVersion(version) { return version.indexOf('rc') == -1; } diff --git a/src/run.ts b/src/run.ts index c13404e..b3669f2 100644 --- a/src/run.ts +++ b/src/run.ts @@ -78,8 +78,8 @@ export async function downloadHelm(version: string): Promise { return helmpath; } -// Downloads the helm release JSON and parses all the recent versions of helm from it. -// Defaults to sending stable helm version if none are valid. +// Downloads the helm releases JSON and parses all the recent versions of helm from it. +// Defaults to sending stable helm version if none are valid or if it fails export async function getLatestHelmVersion(): Promise { let helmJSONPath:string = await toolCache.downloadTool(helmAllReleasesUrl); @@ -99,7 +99,7 @@ export async function getLatestHelmVersion(): Promise { return stableHelmVersion; } -// isValidVersion checks if verison matches the specified type and is a stable release +// isValidVersion checks if verison is a stable release function isValidVersion(version: string): boolean { return version.indexOf('rc') == -1; }