pre-commit/pre-commit-hooks
1
0
Fork 0
mirror of https://github.com/pre-commit/pre-commit-hooks.git synced 2026-07-01 15:09:33 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

[ISS-1258][DC] update tests for coverage

Browse source
This commit is contained in:
DanielConnelly 2026-06-02 16:10:43 +01:00
parent 901b6c8dce
commit ca458c68af
No known key found for this signature in database
2 changed files with 33 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

7
testing/resources/aws_temp_credentials_secrets_file.json Normal file
View file

@ -0,0 +1,7 @@
{
"Credentials": {
"AccessKeyId": "tempAccessKeyId",
"SecretAccessKey": "tempSecretAccessKey",
"SessionToken": "tempSessionToken"
}
}

26
tests/detect_aws_credentials_test.py
View file

@ -80,6 +80,14 @@ def test_get_aws_secrets_from_env(env_vars, values):
'tempSessionToken', 'tempSessionToken',
}, },
), ),
(
'aws_temp_credentials_secrets_file.json',
{
'tempAccessKeyId',
'tempSecretAccessKey',
'tempSessionToken',
},
),
('nonsense.txt', set()), ('nonsense.txt', set()),
('ok_json.json', set()), ('ok_json.json', set()),
), ),
@ -141,6 +149,8 @@ def test_detect_aws_credentials(filename, expected_retval):
get_resource_path(filename), get_resource_path(filename),
'--credentials-file', '--credentials-file',
'testing/resources/aws_config_with_multiple_sections.ini', 'testing/resources/aws_config_with_multiple_sections.ini',
'--json-credentials-dir',
'testing/resources/',
)) ))
assert ret == expected_retval assert ret == expected_retval
@ -167,6 +177,7 @@ def test_non_existent_credentials(mock_secrets_env, mock_secrets_file, capsys):
ret = main(( ret = main((
get_resource_path('aws_config_without_secrets.ini'), get_resource_path('aws_config_without_secrets.ini'),
'--credentials-file=testing/resources/credentailsfilethatdoesntexist', '--credentials-file=testing/resources/credentailsfilethatdoesntexist',
'--json-credentials-dir=directorythatdoesnotexist',
)) ))
assert ret == 2 assert ret == 2
out, _ = capsys.readouterr() out, _ = capsys.readouterr()
@ -190,3 +201,18 @@ def test_non_existent_credentials_with_allow_flag(
'--allow-missing-credentials', '--allow-missing-credentials',
)) ))
assert ret == 0 assert ret == 0
@patch('pre_commit_hooks.detect_aws_credentials.get_aws_secrets_from_file')
@patch('pre_commit_hooks.detect_aws_credentials.get_aws_secrets_from_env')
def test_non_existent_json_credentials_with_allow_flag(
mock_secrets_env, mock_secrets_file,
):
mock_secrets_env.return_value = set()
mock_secrets_file.return_value = set()
ret = main((
get_resource_path('aws_config_without_secrets.ini'),
'--json-credentials-file=credentailsfilethatdoesntexist',
'--allow-missing-credentials',
))
assert ret == 0