deleted unnecessary manual testing files an folders

This commit is contained in:
Alvaro Andrés Rodríguez Scelza 2019-06-13 21:44:33 -03:00
parent 8e79502b8a
commit bc7315b861
60 changed files with 1 additions and 1450 deletions

View file

@ -6,7 +6,7 @@ omit =
.tox/*
/usr/*
setup.py
pre_commit_hooks/loaderon_hooks/tests/automatic_testing/testing_samples/*
pre_commit_hooks/loaderon_hooks/tests/testing_samples/*
[report]
show_missing = True

View file

@ -4,12 +4,3 @@ ALL pre_commit_hooks tests, not only Loaderon's):
coverage erase
coverage run --source pre_commit_hooks -m pytest
coverage report
#######################################################################################################################
Each automatic test method should have three stages:
-Initialization: declaring and specification of all necessary variables and data for the test.
-Execution: run all to-be-tested procedures.
-Restoration: Eventual undoing of actions that may have changed external configurations. So as to ensure unit testing
isolation. Restoration should go before verification in case test fails.
-Verification: checking of obtained results. Might not be necessary when an exception is expected.

View file

@ -1,10 +0,0 @@
Inside pre_commit_hooks/loaderon_hooks/tests/manual_testing you can find several finds which function is to allow
quick manual testing of any developed hook.
runner.py is in charge of calling the main function of any hook file, and thus trigger that hook by passing
a to-be-tested file as parameter. The hook will take that file and run it's checks, potentially allowing us to debug
and therefore find possible problems.
testing_class.py is a to-be-tested file example, used to test check_class_docstring hook.
testing_view.xml is a to-be-tested file example, used to test check_view_name Odoo specific hook.

View file

@ -1,37 +0,0 @@
import subprocess
import sys
import uuid
import pytest
from pre_commit_hooks.loaderon_hooks.general_hooks.check_branch_name import main
@pytest.fixture(autouse=True)
def clean_sys_argv():
sys.argv = []
yield
def test_branch_name_ok():
new_branch_name = str(uuid.uuid4())
subprocess.check_output(['git', 'checkout', '-b', new_branch_name])
sys.argv.append('--regex')
sys.argv.append(r'\b(?!master)\b\S+')
result = main(sys.argv)
subprocess.check_output(['git', 'checkout', 'master'])
subprocess.check_output(['git', 'branch', '-d', new_branch_name])
assert result == 0
def test_branch_name_error():
subprocess.check_output(['git', 'checkout', 'master'])
sys.argv.append('--regex')
sys.argv.append(r'\b(?!master)\b\S+')
result = main(sys.argv)
assert result == 2

View file

@ -1,45 +0,0 @@
import sys
import pytest
from pre_commit_hooks.loaderon_hooks.tests.automatic_testing.util.test_helpers import \
perform_test_on_file_expecting_result
from pre_commit_hooks.loaderon_hooks.general_hooks.check_class_docstring import main
@pytest.fixture(autouse=True)
def clean_():
sys.argv = []
yield
def test_docstring_ok():
perform_test_on_file_expecting_result('check_class_docstring_samples/docstring_ok.py', main)
def test_docstring_error_1():
perform_test_on_file_expecting_result('check_class_docstring_samples/docstring_error_1.py', main, expected_result=2)
def test_docstring_error_2():
perform_test_on_file_expecting_result('check_class_docstring_samples/docstring_error_2.py', main, expected_result=2)
def test_docstring_error_3():
perform_test_on_file_expecting_result('check_class_docstring_samples/docstring_error_3.py', main, expected_result=2)
def test_docstring_error_4():
perform_test_on_file_expecting_result('check_class_docstring_samples/docstring_error_4.py', main, expected_result=2)
def test_docstring_error_5():
perform_test_on_file_expecting_result('check_class_docstring_samples/docstring_error_5.py', main, expected_result=2)
def test_docstring_error_6():
perform_test_on_file_expecting_result('check_class_docstring_samples/docstring_error_6.py', main, expected_result=2)
def test_docstring_error_7():
perform_test_on_file_expecting_result('check_class_docstring_samples/docstring_error_7.py', main, expected_result=2)

View file

@ -1,49 +0,0 @@
import sys
import pytest
from pre_commit_hooks.loaderon_hooks.tests.automatic_testing.util.test_helpers import \
perform_test_on_file_expecting_result
from pre_commit_hooks.loaderon_hooks.general_hooks.check_line import main
@pytest.fixture(autouse=True)
def clean_sys_argv():
sys.argv = []
# Multiple checks, one regexp per type of line to check.
sys.argv.append('--line-to-check')
sys.argv.append(r'^(\t| )*<field.+')
sys.argv.append('--line-to-check')
sys.argv.append(r'^(\t| )*<record.+')
sys.argv.append('--line-to-check')
sys.argv.append(r'.+fields.Many2one.+')
sys.argv.append('--line-to-check')
sys.argv.append(r'.+fields.One2many.+')
sys.argv.append('--line-to-check')
sys.argv.append(r'.+fields.Many2many.+')
sys.argv.append('--line-to-check')
sys.argv.append(r'class.+')
# Regexp for knowing how the line must be in order to be correct.
sys.argv.append('--regexp-to-match')
sys.argv.append(r'^(\t| )*<field name=".+"')
sys.argv.append('--regexp-to-match')
sys.argv.append(r'^(\t| )*<record id=".+"')
sys.argv.append('--regexp-to-match')
sys.argv.append(r'^(\t| )*.+_id = fields.Many2one\(')
sys.argv.append('--regexp-to-match')
sys.argv.append(r'^(\t| )*.+_ids = fields.One2many\(')
sys.argv.append('--regexp-to-match')
sys.argv.append(r'^(\t| )*.+_ids = fields.Many2many\(')
sys.argv.append('--regexp-to-match')
sys.argv.append(r'class ([A-Z]+[a-z0-9]+)+\(models.Model\):')
yield
def test_odoo_xml_field_and_record_declaration_ok():
perform_test_on_file_expecting_result('check_line_samples/xml_lines_ok.xml', main)
def test_odoo_xml_record_declaration_error():
perform_test_on_file_expecting_result('check_line_samples/xml_lines_error_1.xml', main, expected_result=2)

View file

@ -1,63 +0,0 @@
import sys
import pytest
from pre_commit_hooks.loaderon_hooks.tests.automatic_testing.util.test_helpers import \
perform_test_on_file_expecting_result
from pre_commit_hooks.loaderon_hooks.general_hooks.check_location import main
@pytest.fixture(autouse=True)
def clean_sys_argv():
sys.argv = []
# Each line is a directory that allows certain types of files.
sys.argv.append('--directories')
sys.argv.append(r'.*\/xml')
sys.argv.append('--directories')
sys.argv.append(r'.*\/javascript')
# Each line specifies what types of files can be located inside the directory.
sys.argv.append('--files')
sys.argv.append(r'correct_xml.xml')
sys.argv.append('--files')
sys.argv.append(r'correct_js.js')
yield
def test_locations_ok_1():
perform_test_on_file_expecting_result('check_location_samples/xml/correct_xml.xml', main)
def test_locations_ok_2():
perform_test_on_file_expecting_result('check_location_samples/javascript/correct_js.js', main)
def test_locations_error1():
perform_test_on_file_expecting_result('check_location_samples/xml/incorrect_js.js', main, expected_result=2)
def test_locations_error2():
perform_test_on_file_expecting_result('check_location_samples/not_enabled_directory/incorrect_xml.xml', main, expected_result=2)
def test_locations_arguments_size_mismatch_error():
sys.argv = []
sys.argv.append('--directories')
sys.argv.append(r'.*\/xml')
# Lacking files for this directory
sys.argv.append('--directories')
sys.argv.append(r'.*\/javascript')
sys.argv.append('--files')
sys.argv.append(r'correct_xml.xml')
perform_test_on_file_expecting_result('check_location_samples/xml/correct_xml.xml', main, expected_result=2)
def test_locations_no_arguments_error():
sys.argv = []
with pytest.raises(TypeError) as error:
perform_test_on_file_expecting_result('check_location_samples/xml/correct_xml.xml', main)
assert "'NoneType' object is not iterable" in str(error.value)

View file

@ -1,47 +0,0 @@
import os
import sys
import sys
import unittest
import mock
import pytest
from pre_commit_hooks.loaderon_hooks.general_hooks.check_using_pylint import main
from pre_commit_hooks.loaderon_hooks.tests.automatic_testing.util.test_helpers import \
perform_test_on_file_expecting_result
@pytest.fixture(autouse=True)
def clean_sys_argv():
sys.argv = []
# What files should we exclude from pylint checker
sys.argv.append('--exclude')
sys.argv.append(r'.*(\/)*incorrect_but_ignored.py')
yield
def test_with_pylint_ok():
perform_test_on_file_expecting_result('check_using_pylint_samples/correct.py', main)
def test_with_pylint_ignored():
perform_test_on_file_expecting_result('check_using_pylint_samples/incorrect_but_ignored.py', main)
def test_with_pylint_error():
perform_test_on_file_expecting_result('check_using_pylint_samples/incorrect.py', main, expected_result=2)
def walk_return(folder_path):
loaderon_hooks_folder = os.path.dirname(folder_path)
root = loaderon_hooks_folder + '/tests/automatic_testing/testing_samples/check_using_pylint_samples'
unused_dirs = []
files = ['.pylintrc']
return [(root, unused_dirs, files)]
class TestWithPylintConf(unittest.TestCase):
@mock.patch('os.walk', side_effect=walk_return)
def test_with_pylint_conf_ok(self, walk_function):
perform_test_on_file_expecting_result('check_using_pylint_samples/correct.py', main)

View file

@ -1,31 +0,0 @@
import sys
import pytest
from pre_commit_hooks.loaderon_hooks.general_hooks.check_xml_encoding import main
from pre_commit_hooks.loaderon_hooks.tests.automatic_testing.util.test_helpers import \
perform_test_on_file_expecting_result
@pytest.fixture(autouse=True)
def clean_sys_argv():
sys.argv = []
# Encoding to be checked
sys.argv.append('--encoding')
sys.argv.append(r'<?xml version="1.0" encoding="utf-8"?>')
yield
def test_check_xml_encoding_ok():
perform_test_on_file_expecting_result('check_xml_encoding_samples/ok.xml', main)
def test_check_xml_encoding_error_1():
perform_test_on_file_expecting_result('check_xml_encoding_samples/no_encoding.xml', main, expected_result=2)
def test_check_xml_encoding_error_2():
perform_test_on_file_expecting_result('check_xml_encoding_samples/first_line_is_empty_space.xml',
main,
expected_result=2)

View file

@ -1,25 +0,0 @@
import sys
import pytest
from pre_commit_hooks.loaderon_hooks.odoo_specific_hooks.check_model_name import main
from pre_commit_hooks.loaderon_hooks.tests.automatic_testing.util.test_helpers import \
perform_test_on_file_expecting_result
@pytest.fixture(autouse=True)
def clean_sys_argv():
sys.argv = []
yield
def test_check_model_name_ok():
perform_test_on_file_expecting_result('check_model_name_samples/ok.py', main)
def test_check_model_name_multiple_inheritance_ok():
perform_test_on_file_expecting_result('check_model_name_samples/multiple_inheritance_ok.py', main)
def test_check_model_name_error():
perform_test_on_file_expecting_result('check_model_name_samples/error.py', main, expected_result=2)

View file

@ -1,29 +0,0 @@
import sys
import pytest
from pre_commit_hooks.loaderon_hooks.odoo_specific_hooks.check_view_fields_order import main
from pre_commit_hooks.loaderon_hooks.tests.automatic_testing.util.test_helpers import \
perform_test_on_file_expecting_result
@pytest.fixture(autouse=True)
def clean_sys_argv():
sys.argv = []
yield
def test_check_view_fields_order_ok():
perform_test_on_file_expecting_result('check_view_fields_order_samples/ok.xml', main)
def test_check_view_fields_order_multiple_records_ok():
perform_test_on_file_expecting_result('check_view_fields_order_samples/multiple_records_ok.xml', main)
def test_check_view_fields_order_name_error():
perform_test_on_file_expecting_result('check_view_fields_order_samples/first_field_not_name_error.xml', main, expected_result=2)
def test_check_view_fields_order_model_error():
perform_test_on_file_expecting_result('check_view_fields_order_samples/second_field_not_model_error.xml', main, expected_result=2)

View file

@ -1,25 +0,0 @@
import sys
import pytest
from pre_commit_hooks.loaderon_hooks.odoo_specific_hooks.check_view_name import main
from pre_commit_hooks.loaderon_hooks.tests.automatic_testing.util.test_helpers import \
perform_test_on_file_expecting_result
@pytest.fixture(autouse=True)
def clean_sys_argv():
sys.argv = []
yield
def test_check_view_name_ok():
perform_test_on_file_expecting_result('check_view_name_samples/ok.xml', main)
def test_check_view_name_inherit_ok():
perform_test_on_file_expecting_result('check_view_name_samples/inherit_ok.xml', main)
def test_check_view_name_error():
perform_test_on_file_expecting_result('check_view_name_samples/error.xml', main, expected_result=2)

View file

@ -1,5 +0,0 @@
# -*- coding: utf-8 -*-
class TestingClass(object): # SHOULD FAIL
""

View file

@ -1,6 +0,0 @@
# -*- coding: utf-8 -*-
class TestingClass(object): # SHOULD FAIL
def foo(self):
pass

View file

@ -1,8 +0,0 @@
# -*- coding: utf-8 -*-
class TestingClass(object): # SHOULD FAIL
def foo(self):
pass
"""Hola mundo"""

View file

@ -1,6 +0,0 @@
# -*- coding: utf-8 -*-
class TestingClass(object): # SHOULD FAIL
"""Hola mundo"""

View file

@ -1,6 +0,0 @@
# -*- coding: utf-8 -*-
class TestingClass(object): # SHOULD FAIL
class InternalTestingClass(object):
"""Hola mundo"""

View file

@ -1,5 +0,0 @@
# -*- coding: utf-8 -*-
class TestingClass(object): # SHOULD FAIL
pass

View file

@ -1,7 +0,0 @@
# -*- coding: utf-8 -*-
class TestingClass(object): # SHOULD FAIL
"""Hola mundo"""
class InternalTestingClass(object):
pass

View file

@ -1,21 +0,0 @@
# -*- coding: utf-8 -*-
class TestingClass(object): # SHOULD PASS
""""""
class TestingClass1(object): # SHOULD PASS
"""
Hola mundo
"""
class TestingClass2(object): # SHOULD PASS
"""Hola mundo"""
class TestingClass3(object): # SHOULD PASS
"""Hola mundo"""
class InternalTestingClass(object):
"""Hola mundo"""

View file

@ -1,9 +0,0 @@
<?xml version="1.0" encoding="utf-8"?>
<odoo>
<data>
<record model="ir.ui.view" id="id">
<field name="name">some.model.form.inherit</field>
<field name="model">some.model</field>
</record>
</data>
</odoo>

View file

@ -1,9 +0,0 @@
<?xml version="1.0" encoding="utf-8"?>
<odoo>
<data>
<record id="id" model="ir.ui.view">
<field name="name">some.model.form.inherit</field>
<field name="model">some.model</field>
</record>
</data>
</odoo>

View file

@ -1,2 +0,0 @@
class SomeClass(object):
_name = "some.model.name"

View file

@ -1,2 +0,0 @@
class SomeClass(object):
_inherit = ['some_model_name', 'some_other_model_name']

View file

@ -1,2 +0,0 @@
class SomeClass(object):
_name = "testing_samples.some.model.name"

View file

@ -1,549 +0,0 @@
[MASTER]
# A comma-separated list of package or module names from where C extensions may
# be loaded. Extensions are loading into the active Python interpreter and may
# run arbitrary code
extension-pkg-whitelist=
# Add files or directories to the blacklist. They should be base names, not
# paths.
ignore=CVS
# Add files or directories matching the regex patterns to the blacklist. The
# regex matches against base names, not paths.
ignore-patterns=
# Python code to execute, usually for sys.path manipulation such as
# pygtk.require().
#init-hook=
# Use multiple processes to speed up Pylint.
jobs=1
# List of plugins (as comma separated values of python modules names) to load,
# usually to register additional checkers.
load-plugins=
# Pickle collected data for later comparisons.
persistent=yes
# Specify a configuration file.
#rcfile=
# When enabled, pylint would attempt to guess common misconfiguration and emit
# user-friendly hints instead of false-positive error messages
suggestion-mode=yes
# Allow loading of arbitrary C extensions. Extensions are imported into the
# active Python interpreter and may run arbitrary code.
unsafe-load-any-extension=no
[MESSAGES CONTROL]
# Only show warnings with the listed confidence levels. Leave empty to show
# all. Valid levels: HIGH, INFERENCE, INFERENCE_FAILURE, UNDEFINED
confidence=
# Disable the message, report, category or checker with the given id(s). You
# can either give multiple identifiers separated by comma (,) or put this
# option multiple times (only on the command line, not in the configuration
# file where it should appear only once).You can also use "--disable=all" to
# disable everything first and then reenable specific checks. For example, if
# you want to run only the similarities checker, you can use "--disable=all
# --enable=similarities". If you want to run only the classes checker, but have
# no Warning level messages displayed, use"--disable=all --enable=classes
# --disable=W"
disable=print-statement,
parameter-unpacking,
unpacking-in-except,
old-raise-syntax,
backtick,
long-suffix,
old-ne-operator,
old-octal-literal,
import-star-module-level,
non-ascii-bytes-literal,
invalid-unicode-literal,
raw-checker-failed,
bad-inline-option,
locally-disabled,
locally-enabled,
file-ignored,
suppressed-message,
useless-suppression,
deprecated-pragma,
apply-builtin,
basestring-builtin,
buffer-builtin,
cmp-builtin,
coerce-builtin,
execfile-builtin,
file-builtin,
long-builtin,
raw_input-builtin,
reduce-builtin,
standarderror-builtin,
unicode-builtin,
xrange-builtin,
coerce-method,
delslice-method,
getslice-method,
setslice-method,
no-absolute-import,
old-division,
dict-iter-method,
dict-view-method,
next-method-called,
metaclass-assignment,
indexing-exception,
raising-string,
reload-builtin,
oct-method,
hex-method,
nonzero-method,
cmp-method,
input-builtin,
round-builtin,
intern-builtin,
unichr-builtin,
map-builtin-not-iterating,
zip-builtin-not-iterating,
range-builtin-not-iterating,
filter-builtin-not-iterating,
using-cmp-argument,
eq-without-hash,
div-method,
idiv-method,
rdiv-method,
exception-message-attribute,
invalid-str-codec,
sys-max-int,
bad-python3-import,
deprecated-string-function,
deprecated-str-translate-call,
deprecated-itertools-function,
deprecated-types-field,
next-method-defined,
dict-items-not-iterating,
dict-keys-not-iterating,
dict-values-not-iterating,
deprecated-operator-function,
deprecated-urllib-function,
xreadlines-attribute,
deprecated-sys-function,
exception-escape,
comprehension-escape,
too-few-public-methods,
import-error,
invalid-name,
missing-docstring
# Enable the message, report, category or checker with the given id(s). You can
# either give multiple identifier separated by comma (,) or put this option
# multiple time (only on the command line, not in the configuration file where
# it should appear only once). See also the "--disable" option for examples.
enable=c-extension-no-member
[REPORTS]
# Python expression which should return a note less than 10 (10 is the highest
# note). You have access to the variables errors warning, statement which
# respectively contain the number of errors / warnings messages and the total
# number of statements analyzed. This is used by the global evaluation report
# (RP0004).
evaluation=10.0 - ((float(5 * error + warning + refactor + convention) / statement) * 10)
# Template used to display messages. This is a python new-style format string
# used to format the message information. See doc for all details
#msg-template=
# Set the output format. Available formats are text, parseable, colorized, json
# and msvs (visual studio).You can also give a reporter class, eg
# mypackage.mymodule.MyReporterClass.
output-format=text
# Tells whether to display a full report or only the messages
reports=no
# Activate the evaluation score.
score=yes
[REFACTORING]
# Maximum number of nested blocks for function / method body
max-nested-blocks=5
# Complete name of functions that never returns. When checking for
# inconsistent-return-statements if a never returning function is called then
# it will be considered as an explicit return statement and no message will be
# printed.
never-returning-functions=optparse.Values,sys.exit
[VARIABLES]
# List of additional names supposed to be defined in builtins. Remember that
# you should avoid to define new builtins when possible.
additional-builtins=
# Tells whether unused global variables should be treated as a violation.
allow-global-unused-variables=yes
# List of strings which can identify a callback function by name. A callback
# name must start or end with one of those strings.
callbacks=cb_,
_cb
# A regular expression matching the name of dummy variables (i.e. expectedly
# not used).
dummy-variables-rgx=_+$|(_[a-zA-Z0-9_]*[a-zA-Z0-9]+?$)|dummy|^ignored_|^unused_
# Argument names that match this expression will be ignored. Default to name
# with leading underscore
ignored-argument-names=_.*|^ignored_|^unused_
# Tells whether we should check for unused import in __init__ files.
init-import=no
# List of qualified module names which can have objects that can redefine
# builtins.
redefining-builtins-modules=six.moves,past.builtins,future.builtins,io,builtins
[TYPECHECK]
# List of decorators that produce context managers, such as
# contextlib.contextmanager. Add to this list to register other decorators that
# produce valid context managers.
contextmanager-decorators=contextlib.contextmanager
# List of members which are set dynamically and missed by pylint inference
# system, and so shouldn't trigger E1101 when accessed. Python regular
# expressions are accepted.
generated-members=
# Tells whether missing members accessed in mixin class should be ignored. A
# mixin class is detected if its name ends with "mixin" (case insensitive).
ignore-mixin-members=yes
# This flag controls whether pylint should warn about no-member and similar
# checks whenever an opaque object is returned when inferring. The inference
# can return multiple potential results while evaluating a Python object, but
# some branches might not be evaluated, which results in partial inference. In
# that case, it might be useful to still emit no-member and other checks for
# the rest of the inferred objects.
ignore-on-opaque-inference=yes
# List of class names for which member attributes should not be checked (useful
# for classes with dynamically set attributes). This supports the use of
# qualified names.
ignored-classes=optparse.Values,thread._local,_thread._local
# List of module names for which member attributes should not be checked
# (useful for modules/projects where namespaces are manipulated during runtime
# and thus existing member attributes cannot be deduced by static analysis. It
# supports qualified module names, as well as Unix pattern matching.
ignored-modules=
# Show a hint with possible names when a member name was not found. The aspect
# of finding the hint is based on edit distance.
missing-member-hint=yes
# The minimum edit distance a name should have in order to be considered a
# similar match for a missing member name.
missing-member-hint-distance=1
# The total number of similar names that should be taken in consideration when
# showing a hint for a missing member.
missing-member-max-choices=1
[MISCELLANEOUS]
# List of note tags to take in consideration, separated by a comma.
notes=FIXME,
XXX
[BASIC]
# Naming style matching correct argument names
argument-naming-style=snake_case
# Regular expression matching correct argument names. Overrides argument-
# naming-style
#argument-rgx=
# Naming style matching correct attribute names
attr-naming-style=snake_case
# Regular expression matching correct attribute names. Overrides attr-naming-
# style
#attr-rgx=
# Bad variable names which should always be refused, separated by a comma
bad-names=foo,
bar,
baz,
toto,
tutu,
tata
# Naming style matching correct class attribute names
class-attribute-naming-style=any
# Regular expression matching correct class attribute names. Overrides class-
# attribute-naming-style
#class-attribute-rgx=
# Naming style matching correct class names
class-naming-style=PascalCase
# Regular expression matching correct class names. Overrides class-naming-style
#class-rgx=
# Naming style matching correct constant names
const-naming-style=UPPER_CASE
# Regular expression matching correct constant names. Overrides const-naming-
# style
#const-rgx=
# Minimum line length for functions/classes that require docstrings, shorter
# ones are exempt.
docstring-min-length=-1
# Naming style matching correct function names
function-naming-style=snake_case
# Regular expression matching correct function names. Overrides function-
# naming-style
#function-rgx=
# Good variable names which should always be accepted, separated by a comma
good-names=i,
j,
k,
ex,
Run,
_
# Naming style matching correct inline iteration names
inlinevar-naming-style=any
# Regular expression matching correct inline iteration names. Overrides
# inlinevar-naming-style
#inlinevar-rgx=
# Naming style matching correct method names
method-naming-style=snake_case
# Regular expression matching correct method names. Overrides method-naming-
# style
#method-rgx=
# Naming style matching correct module names
module-naming-style=snake_case
# Regular expression matching correct module names. Overrides module-naming-
# style
#module-rgx=
# Colon-delimited sets of names that determine each other's naming style when
# the name regexes allow several styles.
name-group=
# Regular expression which should only match function or class names that do
# not require a docstring.
no-docstring-rgx=^_
# List of decorators that produce properties, such as abc.abstractproperty. Add
# to this list to register other decorators that produce valid properties.
property-classes=abc.abstractproperty
# Naming style matching correct variable names
variable-naming-style=snake_case
# Regular expression matching correct variable names. Overrides variable-
# naming-style
#variable-rgx=
[SPELLING]
# Limits count of emitted suggestions for spelling mistakes
max-spelling-suggestions=4
# Spelling dictionary name. Available dictionaries: none. To make it working
# install python-enchant package.
spelling-dict=
# List of comma separated words that should not be checked.
spelling-ignore-words=
# A path to a file that contains private dictionary; one word per line.
spelling-private-dict-file=
# Tells whether to store unknown words to indicated private dictionary in
# --spelling-private-dict-file option instead of raising a message.
spelling-store-unknown-words=no
[LOGGING]
# Logging modules to check that the string format arguments are in logging
# function parameter format
logging-modules=logging
[FORMAT]
# Expected format of line ending, e.g. empty (any line ending), LF or CRLF.
expected-line-ending-format=
# Regexp for a line that is allowed to be longer than the limit.
ignore-long-lines=^\s*(# )?<?https?://\S+>?$
# Number of spaces of indent required inside a hanging or continued line.
indent-after-paren=4
# String used as indentation unit. This is usually " " (4 spaces) or "\t" (1
# tab).
indent-string=' '
# Maximum number of characters on a single line.
max-line-length=120
# Maximum number of lines in a module
max-module-lines=1000
# List of optional constructs for which whitespace checking is disabled. `dict-
# separator` is used to allow tabulation in dicts, etc.: {1 : 1,\n222: 2}.
# `trailing-comma` allows a space between comma and closing bracket: (a, ).
# `empty-line` allows space-only lines.
no-space-check=trailing-comma,
dict-separator
# Allow the body of a class to be on the same line as the declaration if body
# contains single statement.
single-line-class-stmt=no
# Allow the body of an if to be on the same line as the test if there is no
# else.
single-line-if-stmt=no
[SIMILARITIES]
# Ignore comments when computing similarities.
ignore-comments=yes
# Ignore docstrings when computing similarities.
ignore-docstrings=yes
# Ignore imports when computing similarities.
ignore-imports=no
# Minimum lines number of a similarity.
min-similarity-lines=4
[CLASSES]
# List of method names used to declare (i.e. assign) instance attributes.
defining-attr-methods=__init__,
__new__,
setUp
# List of member names, which should be excluded from the protected access
# warning.
exclude-protected=_asdict,
_fields,
_replace,
_source,
_make
# List of valid names for the first argument in a class method.
valid-classmethod-first-arg=cls
# List of valid names for the first argument in a metaclass class method.
valid-metaclass-classmethod-first-arg=mcs
[DESIGN]
# Maximum number of arguments for function / method
max-args=5
# Maximum number of attributes for a class (see R0902).
max-attributes=7
# Maximum number of boolean expressions in a if statement
max-bool-expr=5
# Maximum number of branch for function / method body
max-branches=12
# Maximum number of locals for function / method body
max-locals=15
# Maximum number of parents for a class (see R0901).
max-parents=7
# Maximum number of public methods for a class (see R0904).
max-public-methods=20
# Maximum number of return / yield for function / method body
max-returns=6
# Maximum number of statements in function / method body
max-statements=50
# Minimum number of public methods for a class (see R0903).
min-public-methods=2
[IMPORTS]
# Allow wildcard imports from modules that define __all__.
allow-wildcard-with-all=no
# Analyse import fallback blocks. This can be used to support both Python 2 and
# 3 compatible code, which means that the block might have code that exists
# only in one or another interpreter, leading to false positives when analysed.
analyse-fallback-blocks=no
# Deprecated modules which should not be used, separated by a comma
deprecated-modules=regsub,
TERMIOS,
Bastion,
rexec
# Create a graph of external dependencies in the given file (report RP0402 must
# not be disabled)
ext-import-graph=
# Create a graph of every (i.e. internal and external) dependencies in the
# given file (report RP0402 must not be disabled)
import-graph=
# Create a graph of internal dependencies in the given file (report RP0402 must
# not be disabled)
int-import-graph=
# Force import order to recognize a module as part of the standard
# compatibility libraries.
known-standard-library=
# Force import order to recognize a module as part of a third party library.
known-third-party=enchant
[EXCEPTIONS]
# Exceptions that will emit a warning when being caught. Defaults to
# "Exception"
overgeneral-exceptions=Exception

View file

@ -1,34 +0,0 @@
# -*- coding: utf-8 -*-
"""This is a module docstring"""
import re
from pre_commit_hooks.loaderon_hooks.util.git_helpers import \
get_current_branch_name
from pre_commit_hooks.loaderon_hooks.util.template_methods.checker_template_method import \
CheckerTemplateMethod
class BranchNameChecker(CheckerTemplateMethod):
"""This is a class docstring"""
def _add_arguments_to_parser(self):
self.parser.add_argument('-r', '--regex', help='Regex that git current branch must match.')
def _perform_checks(self):
super(BranchNameChecker, self)._perform_checks()
regular_expression = self.args.regex
pattern = re.compile(regular_expression)
current_branch_name = get_current_branch_name()
if not pattern.match(current_branch_name):
self.inform_check_failure('El nombre de la rama debe ser del estilo {}'
.format(regular_expression))
def main(argv=None):
"""This is a function docstring"""
return BranchNameChecker(argv).run()
if __name__ == '__main__':
exit(main())

View file

@ -1,26 +0,0 @@
# -*- coding: utf-8 -*-
import re
from pre_commit_hooks.loaderon_hooks.util.git_helpers import get_current_branch_name
from pre_commit_hooks.loaderon_hooks.util.template_methods.checker_template_method import CheckerTemplateMethod
class BranchNameChecker(CheckerTemplateMethod):
def _add_arguments_to_parser(self):
self.parser.add_argument('-r', '--regex', help='Regex that git current branch must match.')
def _perform_checks(self):
super(BranchNameChecker, self)._perform_checks()
regular_expression = self.args.regex
pattern = re.compile(regular_expression)
current_branch_name = get_current_branch_name()
if not pattern.match(current_branch_name):
self.inform_check_failure('El nombre de la rama debe ser del estilo {}'.format(regular_expression))
def main(argv=None):
return BranchNameChecker(argv).run()
if __name__ == '__main__':
exit(main())

View file

@ -1,26 +0,0 @@
# -*- coding: utf-8 -*-
import re
from pre_commit_hooks.loaderon_hooks.util.git_helpers import get_current_branch_name
from pre_commit_hooks.loaderon_hooks.util.template_methods.checker_template_method import CheckerTemplateMethod
class BranchNameChecker(CheckerTemplateMethod):
def _add_arguments_to_parser(self):
self.parser.add_argument('-r', '--regex', help='Regex that git current branch must match.')
def _perform_checks(self):
super(BranchNameChecker, self)._perform_checks()
regular_expression = self.args.regex
pattern = re.compile(regular_expression)
current_branch_name = get_current_branch_name()
if not pattern.match(current_branch_name):
self.inform_check_failure('El nombre de la rama debe ser del estilo {}'.format(regular_expression))
def main(argv=None):
return BranchNameChecker(argv).run()
if __name__ == '__main__':
exit(main())

View file

@ -1,9 +0,0 @@
<?xml version="1.0" encoding="utf-8"?>
<odoo>
<data>
<record id="id" model="ir.ui.view">
<field name="not-name-tag">Jhon Doe</field>
<field name="model">some.model</field>
</record>
</data>
</odoo>

View file

@ -1,14 +0,0 @@
<?xml version="1.0" encoding="utf-8"?>
<odoo>
<data>
<record id="id" model="ir.ui.view">
<field name="name">some.model.form.inherit</field>
<field name="model">some.model</field>
</record>
<record id="another_id" model="ir.ui.view">
<field name="name">some.another.model.form.inherit</field>
<field name="model">some.another.model</field>
</record>
</data>
</odoo>

View file

@ -1,9 +0,0 @@
<?xml version="1.0" encoding="utf-8"?>
<odoo>
<data>
<record id="id" model="ir.ui.view">
<field name="name">some.model.form.inherit</field>
<field name="model">some.model</field>
</record>
</data>
</odoo>

View file

@ -1,9 +0,0 @@
<?xml version="1.0" encoding="utf-8"?>
<odoo>
<data>
<record id="id" model="ir.ui.view">
<field name="name">some.model.form.inherit</field>
<field name="not-model-tag">Jhon Doe</field>
</record>
</data>
</odoo>

View file

@ -1,9 +0,0 @@
<record id="an_id" model="ir.ui.view">
<field name="name">bad_name</field>
<field name="model">model_name</field>
<field name="arch" type="xml">
<search string="Some search conf">
<field name="some_field"/>
</search>
</field>
</record>

View file

@ -1,9 +0,0 @@
<record id="an_id" model="ir.ui.view">
<field name="name">model_name.search.inherit</field>
<field name="model">model_name</field>
<field name="arch" type="xml">
<search string="Some search conf">
<field name="some_field"/>
</search>
</field>
</record>

View file

@ -1,9 +0,0 @@
<record id="an_id" model="ir.ui.view">
<field name="name">model_name.search</field>
<field name="model">model_name</field>
<field name="arch" type="xml">
<search string="Some search conf">
<field name="some_field"/>
</search>
</field>
</record>

View file

@ -1,10 +0,0 @@
<?xml version="1.0" encoding="utf-8"?>
<odoo>
<data>
<record id="id" model="ir.ui.view">
<field name="name">some.model.form.inherit</field>
<field name="model">some.model</field>
</record>
</data>
</odoo>

View file

@ -1,8 +0,0 @@
<odoo>
<data>
<record id="id" model="ir.ui.view">
<field name="name">some.model.form.inherit</field>
<field name="model">some.model</field>
</record>
</data>
</odoo>

View file

@ -1,9 +0,0 @@
<?xml version="1.0" encoding="utf-8"?>
<odoo>
<data>
<record id="id" model="ir.ui.view">
<field name="name">some.model.form.inherit</field>
<field name="model">some.model</field>
</record>
</data>
</odoo>

View file

@ -1,17 +0,0 @@
import os
import sys
def get_sample_file_path(file_name):
current_path = os.path.dirname(os.path.dirname(os.path.abspath(__file__)))
testing_files_folder_path = current_path + '/testing_samples/'
return testing_files_folder_path + file_name
def perform_test_on_file_expecting_result(file_name, test_function, expected_result=0):
sample_file_path = get_sample_file_path(file_name)
sys.argv.append(sample_file_path)
result = test_function(sys.argv)
assert result == expected_result

View file

@ -1,184 +0,0 @@
# -*- coding: utf-8 -*-
import sys
from pre_commit_hooks.loaderon_hooks.general_hooks.check_branch_name import BranchNameChecker
from pre_commit_hooks.loaderon_hooks.general_hooks.check_class_docstring import ClassDocstringChecker
from pre_commit_hooks.loaderon_hooks.general_hooks.check_line import LinesChecker
from pre_commit_hooks.loaderon_hooks.general_hooks.check_location import LocationChecker
from pre_commit_hooks.loaderon_hooks.general_hooks.check_using_pylint import PylintChecker
from pre_commit_hooks.loaderon_hooks.general_hooks.check_xml_encoding import XMLEncodingChecker
from pre_commit_hooks.loaderon_hooks.odoo_specific_hooks.check_model_name import ModelNameAttributeChecker
xml_testing_file_path = r'C:\Users\Loaderon\Desktop\pre-commit-hooks\pre_commit_hooks\loaderon_hooks\tests\manual_testing\testing_view.xml'
py_testing_file_path = r'C:\Users\Loaderon\Desktop\pre-commit-hooks\pre_commit_hooks\loaderon_hooks\tests\manual_testing\testing_class.py'
def run_model_name_checker():
sys.argv.append(xml_testing_file_path)
return ModelNameAttributeChecker(sys.argv).run()
def run_branch_name_checker():
sys.argv.append('--regex')
sys.argv.append(r'\b(?!master)\b\S+')
return BranchNameChecker(sys.argv).run()
def run_docstring_checker():
sys.argv.append(py_testing_file_path)
return ClassDocstringChecker(sys.argv).run()
def run_line_checker():
# Multiple checks, one regexp per type of line to check.
sys.argv.append('--line-to-check')
sys.argv.append(r'^(\t| )*<field.+')
sys.argv.append('--line-to-check')
sys.argv.append(r'^(\t| )*<record.+')
sys.argv.append('--line-to-check')
sys.argv.append(r'.+fields.Many2one.+')
sys.argv.append('--line-to-check')
sys.argv.append(r'.+fields.One2many.+')
sys.argv.append('--line-to-check')
sys.argv.append(r'.+fields.Many2many.+')
sys.argv.append('--line-to-check')
sys.argv.append(r'class.+')
# Regexp for knowing how the line must be in order to be correct.
sys.argv.append('--regexp-to-match')
sys.argv.append(r'^(\t| )*<field name=".+"')
sys.argv.append('--regexp-to-match')
sys.argv.append(r'^(\t| )*<record id=".+"')
sys.argv.append('--regexp-to-match')
sys.argv.append(r'^(\t| )*.+_id = fields.Many2one\(')
sys.argv.append('--regexp-to-match')
sys.argv.append(r'^(\t| )*.+_ids = fields.One2many\(')
sys.argv.append('--regexp-to-match')
sys.argv.append(r'^(\t| )*.+_ids = fields.Many2many\(')
sys.argv.append('--regexp-to-match')
sys.argv.append(r'class ([A-Z]+[a-z0-9]+)+\(models.Model\):')
sys.argv.append(py_testing_file_path)
return LinesChecker(sys.argv).run()
def run_location_checker():
# Each line is a directory that allows certain types of files.
sys.argv.append('--directories')
sys.argv.append(r'^[^\/]+$')
sys.argv.append('--directories')
sys.argv.append(r'.*\/controllers$')
sys.argv.append('--directories')
sys.argv.append(r'.*\/data$')
sys.argv.append('--directories')
sys.argv.append(r'.*\/i18n$')
sys.argv.append('--directories')
sys.argv.append(r'.*\/models$')
sys.argv.append('--directories')
sys.argv.append(r'.*\/report$')
sys.argv.append('--directories')
sys.argv.append(r'.*\/security$')
sys.argv.append('--directories')
sys.argv.append(r'.*\/static\/img$')
sys.argv.append('--directories')
sys.argv.append(r'.*\/static\/lib\/external_lib$')
sys.argv.append('--directories')
sys.argv.append(r'.*\/static\/src\/js$')
sys.argv.append('--directories')
sys.argv.append(r'.*\/static\/src\/css$')
sys.argv.append('--directories')
sys.argv.append(r'.*\/static\/src\/less$')
sys.argv.append('--directories')
sys.argv.append(r'.*\/static\/src\/xml$')
sys.argv.append('--directories')
sys.argv.append(r'.*\/static\/tests$')
sys.argv.append('--directories')
sys.argv.append(r'.*[^\/static]\/tests$')
sys.argv.append('--directories')
sys.argv.append(r'.*\/views$')
sys.argv.append('--directories')
sys.argv.append(r'.*\/wizard$')
# Each line specifies what types of files can be located inside the directory.
sys.argv.append('--files')
sys.argv.append(r'__init__.py$ __openerp__.py$')
sys.argv.append('--files')
sys.argv.append(r'__init__.py$ .*\.py$ main.py$')
sys.argv.append('--files')
sys.argv.append(r'.*_data\.xml$ .*_demo\.xml$')
sys.argv.append('--files')
sys.argv.append(r'.*\.po$')
sys.argv.append('--files')
sys.argv.append(r'__init__.py$ .*\.py$')
sys.argv.append('--files')
sys.argv.append(r'__init__.py$ .*\.py$ .*_views\.xml$ .*_reports\.xml$ .*_templates\.xml$')
sys.argv.append('--files')
sys.argv.append(r'ir.model.access.csv$ .*_security\.xml$')
sys.argv.append('--files')
sys.argv.append(r'.*\.png$ .*\.jpg$')
sys.argv.append('--files')
sys.argv.append(r'.*\$')
sys.argv.append('--files')
sys.argv.append(r'.*\.js$')
sys.argv.append('--files')
sys.argv.append(r'.*\.css$')
sys.argv.append('--files')
sys.argv.append(r'.*\.less$')
sys.argv.append('--files')
sys.argv.append(r'.*\.xml$')
sys.argv.append('--files')
sys.argv.append(r'.*\.tour\.js$')
sys.argv.append('--files')
sys.argv.append(r'__init__.py$ test_.*\.py')
sys.argv.append('--files')
sys.argv.append(r'.*_templates\.xml$ .*_views\.xml$')
sys.argv.append('--files')
sys.argv.append(r'.*\.py$ .*_views\.xml$')
sys.argv.append(py_testing_file_path)
return LocationChecker(sys.argv).run()
def run_pylint_checker():
# What files should we exclude from pylint checker
sys.argv.append('--exclude')
sys.argv.append(r'.*(\/)*__openerp__.py$')
sys.argv.append(py_testing_file_path)
return PylintChecker(sys.argv).run()
def run_xml_encoding():
# Encoding to be checked
sys.argv.append('--encoding')
sys.argv.append(r'<?xml version="1.0" encoding="utf-8"?>')
sys.argv.append(xml_testing_file_path)
return XMLEncodingChecker(sys.argv).run()
def main():
# comment or remove a function no to be tested
functions = [run_model_name_checker,
run_branch_name_checker,
run_docstring_checker,
run_line_checker,
run_location_checker,
run_pylint_checker,
run_xml_encoding]
for function in functions:
sys.argv = []
print('')
print('----------------------------------')
print('Test: ' + function.__name__)
print('')
function()
if __name__ == '__main__':
exit(main())

View file

@ -1,51 +0,0 @@
# -*- coding: utf-8 -*-
class TestingClass(object): # SHOULD FAIL
pass
class TestingClass2(object): # SHOULD PASS
""""""
class TestingClass3(object): # SHOULD PASS
"""
Hola mundo
"""
class TestingClass4(object): # SHOULD FAIL
""
class TestingClass5(object): # SHOULD FAIL
def foo(self):
pass
class TestingClass6(object): # SHOULD FAIL
def foo(self):
pass
"""Hola mundo"""
class TestingClass7(object): # SHOULD FAIL
"""Hola mundo"""
class TestingClass8(object): # SHOULD PASS
"""Hola mundo"""
class TestingClass9(object): # SHOULD FAIL
class TestingClass10(object):
"""Hola mundo"""
class TestingClass11(object): # SHOULD PASS
"""Hola mundo"""
class TestingClass12(object):
"""Hola mundo"""

View file

@ -1,9 +0,0 @@
<?xml version="1.0" encoding="utf-8"?>
<odoo>
<data>
<record id="id" model="ir.ui.view">
<field name="name">some.model.form.inherit</field>
<field name="model">some.model</field>
</record>
</data>
</odoo>