From b0d44c7084461e23c16798a3dc3d5d65dfd3f97e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Socho=C5=84?= Date: Mon, 26 Mar 2018 00:17:13 +0200 Subject: [PATCH] Ensure not to alter list in 'for' loop --- pre_commit_hooks/requirements_txt_fixer.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/pre_commit_hooks/requirements_txt_fixer.py b/pre_commit_hooks/requirements_txt_fixer.py index ee432cb..135fe2e 100644 --- a/pre_commit_hooks/requirements_txt_fixer.py +++ b/pre_commit_hooks/requirements_txt_fixer.py @@ -71,9 +71,10 @@ def fix_requirements(f): # find and remove pkg-resources==0.0.0 # which is automatically added by broken pip package under Debian - for requirement in requirements: - if requirement.value == b'pkg-resources==0.0.0\n': - requirements.remove(requirement) + requirements = [ + requirement for requirement in requirements + if requirement.value != b'pkg-resources==0.0.0\n' + ] for requirement in sorted(requirements): after.extend(requirement.comments)