pre-commit/pre-commit-hooks
1
0
Fork 0
mirror of https://github.com/pre-commit/pre-commit-hooks.git synced 2026-04-06 20:16:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #425 from vinayinvicible/url-req

Browse source 
Fixed sorting for non editable requirement urls
This commit is contained in:
Anthony Sottile 2019-11-15 14:21:49 -08:00 • committed by GitHub
commit 8a36145fa9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
pre_commit_hooks/requirements_txt_fixer.py
View file

@ -21,8 +21,9 @@ class Requirement(object):
@property @property
def name(self): # type: () -> bytes def name(self): # type: () -> bytes
assert self.value is not None, self.value assert self.value is not None, self.value
if self.value.startswith(b'-e '): for egg in (b'#egg=', b'&egg='):
return self.value.lower().partition(b'=')[-1] if egg in self.value:
return self.value.lower().partition(egg)[-1]
return self.value.lower().partition(b'==')[0] return self.value.lower().partition(b'==')[0]

5
tests/requirements_txt_fixer_test.py
View file

@ -45,6 +45,11 @@ from pre_commit_hooks.requirements_txt_fixer import Requirement
), ),
(b'bar\npkg-resources==0.0.0\nfoo\n', FAIL, b'bar\nfoo\n'), (b'bar\npkg-resources==0.0.0\nfoo\n', FAIL, b'bar\nfoo\n'),
(b'foo\npkg-resources==0.0.0\nbar\n', FAIL, b'bar\nfoo\n'), (b'foo\npkg-resources==0.0.0\nbar\n', FAIL, b'bar\nfoo\n'),
(
b'git+ssh://git_url@tag#egg=ocflib\nDjango\nijk\n',
FAIL,
b'Django\nijk\ngit+ssh://git_url@tag#egg=ocflib\n',
),
), ),
) )
def test_integration(input_s, expected_retval, output, tmpdir): def test_integration(input_s, expected_retval, output, tmpdir):