Merge pull request #425 from vinayinvicible/url-req

Fixed sorting for non editable requirement urls
This commit is contained in:
Anthony Sottile 2019-11-15 14:21:49 -08:00 committed by GitHub
commit 8a36145fa9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 2 deletions

View file

@ -21,8 +21,9 @@ class Requirement(object):
@property
def name(self): # type: () -> bytes
assert self.value is not None, self.value
if self.value.startswith(b'-e '):
return self.value.lower().partition(b'=')[-1]
for egg in (b'#egg=', b'&egg='):
if egg in self.value:
return self.value.lower().partition(egg)[-1]
return self.value.lower().partition(b'==')[0]

View file

@ -45,6 +45,11 @@ from pre_commit_hooks.requirements_txt_fixer import Requirement
),
(b'bar\npkg-resources==0.0.0\nfoo\n', FAIL, b'bar\nfoo\n'),
(b'foo\npkg-resources==0.0.0\nbar\n', FAIL, b'bar\nfoo\n'),
(
b'git+ssh://git_url@tag#egg=ocflib\nDjango\nijk\n',
FAIL,
b'Django\nijk\ngit+ssh://git_url@tag#egg=ocflib\n',
),
),
)
def test_integration(input_s, expected_retval, output, tmpdir):