pre-commit/pre-commit-hooks
1
0
Fork 0
mirror of https://github.com/pre-commit/pre-commit-hooks.git synced 2026-04-09 04:54:16 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix requirements-txt-fixer for comments at end of file

Browse source
This commit is contained in:
Anthony Sottile 2017-10-09 10:59:17 -07:00
parent 5d08e77ad5
commit 86691eda47
2 changed files with 9 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

7
pre_commit_hooks/requirements_txt_fixer.py
View file

@ -63,9 +63,16 @@ def fix_requirements(f):
else: else:
requirement.value = line requirement.value = line
# if a file ends in a comment, preserve it at the end
if requirements[-1].value is None:
rest = requirements.pop().comments
else:
rest = []
for requirement in sorted(requirements): for requirement in sorted(requirements):
after.extend(requirement.comments) after.extend(requirement.comments)
after.append(requirement.value) after.append(requirement.value)
after.extend(rest)
after_string = b''.join(after) after_string = b''.join(after)

2
tests/requirements_txt_fixer_test.py
View file

@ -11,6 +11,8 @@ from pre_commit_hooks.requirements_txt_fixer import Requirement
( (
(b'', PASS, b''), (b'', PASS, b''),
(b'\n', PASS, b'\n'), (b'\n', PASS, b'\n'),
(b'# intentionally empty\n', PASS, b'# intentionally empty\n'),
(b'foo\n# comment at end\n', PASS, b'foo\n# comment at end\n'),
(b'foo\nbar\n', FAIL, b'bar\nfoo\n'), (b'foo\nbar\n', FAIL, b'bar\nfoo\n'),
(b'bar\nfoo\n', PASS, b'bar\nfoo\n'), (b'bar\nfoo\n', PASS, b'bar\nfoo\n'),
(b'#comment1\nfoo\n#comment2\nbar\n', FAIL, b'#comment2\nbar\n#comment1\nfoo\n'), (b'#comment1\nfoo\n#comment2\nbar\n', FAIL, b'#comment2\nbar\n#comment1\nfoo\n'),