From 846dd4f6dd6044191d73b7f3d24246991ad51593 Mon Sep 17 00:00:00 2001 From: zsxoff Date: Mon, 18 May 2020 01:03:40 +0400 Subject: [PATCH] pytype: pass str filename to xml.sax.parse, not BinaryIO --- pre_commit_hooks/check_xml.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/pre_commit_hooks/check_xml.py b/pre_commit_hooks/check_xml.py index 59b4d59..25ddb3c 100644 --- a/pre_commit_hooks/check_xml.py +++ b/pre_commit_hooks/check_xml.py @@ -13,8 +13,7 @@ def main(argv: Optional[Sequence[str]] = None) -> int: handler = xml.sax.handler.ContentHandler() for filename in args.filenames: try: - with open(filename, 'rb') as xml_file: - xml.sax.parse(xml_file, handler) + xml.sax.parse(filename, handler) except xml.sax.SAXException as exc: print(f'{filename}: Failed to xml parse ({exc})') retval = 1