pre-commit/pre-commit-hooks
1
0
Fork 0
mirror of https://github.com/pre-commit/pre-commit-hooks.git synced 2026-04-02 02:56:52 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix NoneTypeError when requirements file is empty

Browse source
This commit is contained in:
Daniel Gallagher 2017-06-23 17:19:21 -07:00
parent 78818b90cd
commit 7ccfa05f2f
2 changed files with 13 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

19
pre_commit_hooks/requirements_txt_fixer.py
View file

@ -30,21 +30,25 @@ class Requirement(object):
def fix_requirements(f):
requirements = []
before = []
before = list(f)
after = []
for line in f:
before.append(line)
before_string = b''.join(before)
# If the most recent requirement object has a value, then it's time to
# start building the next requirement object.
# If the file is empty (i.e. only whitespace/newlines) exit early
if before_string.strip() == b'':
return 0
for line in before:
# If the most recent requirement object has a value, then it's
# time to start building the next requirement object.
if not len(requirements) or requirements[-1].value is not None:
requirements.append(Requirement())
requirement = requirements[-1]
# If we see a newline before any requirements, then this is a top of
# file comment.
# If we see a newline before any requirements, then this is a
# top of file comment.
if len(requirements) == 1 and line.strip() == b'':
if len(requirement.comments) and requirement.comments[0].startswith(b'#'):
requirement.value = b'\n'
@ -60,7 +64,6 @@ def fix_requirements(f):
after.append(comment)
after.append(requirement.value)
before_string = b''.join(before)
after_string = b''.join(after)
if before_string == after_string: