pre-commit/pre-commit-hooks
1
0
Fork 0
mirror of https://github.com/pre-commit/pre-commit-hooks.git synced 2026-04-09 12:54:17 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #260 from PVSec/master

Browse source 
Fix for issue #258
This commit is contained in:
Anthony Sottile 2018-01-26 15:34:24 -08:00 • committed by GitHub
commit 79915aa6ef
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 9 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
pre_commit_hooks/detect_aws_credentials.py
View file

@ -53,7 +53,9 @@ def get_aws_secrets_from_file(credentials_file):
'aws_session_token', 'aws_session_token',
): ):
try: try:
keys.add(parser.get(section, var)) key = parser.get(section, var).strip()
if key:
keys.add(key)
except configparser.NoOptionError: except configparser.NoOptionError:
pass pass
return keys return keys

4
testing/resources/aws_config_without_secrets_with_spaces.ini Normal file
View file

@ -0,0 +1,4 @@
# file with an AWS access key id but no valid AWS secret access key only space characters
[production]
aws_access_key_id = AKIASLARTARGENTINA86
aws_secret_access_key =

2
tests/detect_aws_credentials_test.py
View file

@ -83,6 +83,7 @@ def test_get_aws_secrets_from_env(env_vars, values):
}, },
), ),
('aws_config_without_secrets.ini', set()), ('aws_config_without_secrets.ini', set()),
('aws_config_without_secrets_with_spaces.ini', set()),
('nonsense.txt', set()), ('nonsense.txt', set()),
('ok_json.json', set()), ('ok_json.json', set()),
), ),
@ -100,6 +101,7 @@ def test_get_aws_secrets_from_file(filename, expected_keys):
('aws_config_with_session_token.ini', 1), ('aws_config_with_session_token.ini', 1),
('aws_config_with_multiple_sections.ini', 1), ('aws_config_with_multiple_sections.ini', 1),
('aws_config_without_secrets.ini', 0), ('aws_config_without_secrets.ini', 0),
('aws_config_without_secrets_with_spaces.ini', 0),
('nonsense.txt', 0), ('nonsense.txt', 0),
('ok_json.json', 0), ('ok_json.json', 0),
), ),