pre-commit/pre-commit-hooks
1
0
Fork 0
mirror of https://github.com/pre-commit/pre-commit-hooks.git synced 2026-03-29 10:16:52 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix mixed-line-endings --fix=... when whole file is a different ending

Browse source
This commit is contained in:
Anthony Sottile 2017-09-27 07:47:24 -07:00
parent efdceb4e40
commit 76047f6eef
2 changed files with 12 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
pre_commit_hooks/mixed_line_ending.py
View file

@ -55,7 +55,8 @@ def fix_filename(filename, fix):
else:
target_ending = FIX_TO_LINE_ENDING[fix]
# find if there are lines with *other* endings
del counts[target_ending]
# It's possible there's no line endings of the target type
counts.pop(target_ending, None)
other_endings = bool(sum(counts.values()))
if other_endings:
_fix(filename, contents, target_ending)

10
tests/mixed_line_ending_test.py
View file

@ -101,3 +101,13 @@ def test_fix_crlf(tmpdir):
assert ret == 1
assert path.read_binary() == b'foo\r\nbar\r\nbaz\r\n'
def test_fix_lf_all_crlf(tmpdir):
"""Regression test for #239"""
path = tmpdir.join('input.txt')
path.write_binary(b'foo\r\nbar\r\n')
ret = main(('--fix=lf', path.strpath))
assert ret == 1
assert path.read_binary() == b'foo\nbar\n'