file-contents-sorter should add newline at end of files missing newlines

Make an explicit 'else' path for readability
This commit is contained in:
Daniel Gallagher 2017-06-25 19:51:50 -07:00
parent 5dd1819e8b
commit 7102e0c8a3
2 changed files with 14 additions and 13 deletions

View file

@ -18,18 +18,19 @@ FAIL = 1
def sort_file_contents(f):
before = [line.strip(b'\n\r') for line in f if line.strip()]
after = sorted(before)
if before == after:
return PASS
before = list(f)
after = sorted([line.strip(b'\n\r') for line in before if line.strip()])
before_string = b''.join(before)
after_string = b'\n'.join(after) + b'\n'
f.seek(0)
f.write(after_string)
f.truncate()
return FAIL
if before_string == after_string:
return PASS
else:
f.seek(0)
f.write(after_string)
f.truncate()
return FAIL
def main(argv=None):