Displaying the filename when the check-json hook fails with a UnicodeDecodeError - fix #148

pre_commit_hooks/check_json.py

@@ -15,7 +15,7 @@ def check_json(argv=None):
     for filename in args.filenames:
         try:
             simplejson.load(open(filename))
-        except simplejson.JSONDecodeError as exc:
+        except (simplejson.JSONDecodeError, UnicodeDecodeError) as exc:
             print('{0}: Failed to json encode ({1})'.format(filename, exc))
             retval = 1
     return retval

testing/resources/bad_json_latin1.nonjson

@@ -0,0 +1,3 @@
+{
+    "И": 1,
+}

tests/check_json_test.py

@@ -6,8 +6,12 @@ from testing.util import get_resource_path
 
 @pytest.mark.parametrize(('filename', 'expected_retval'), (
     ('bad_json.notjson', 1),
+    ('bad_json_latin1.nonjson', 1),
     ('ok_json.json', 0),
 ))
-def test_check_json(filename, expected_retval):
+def test_check_json(capsys, filename, expected_retval):
     ret = check_json([get_resource_path(filename)])
     assert ret == expected_retval
+    if expected_retval == 1:
+        stdout, _ = capsys.readouterr()
+        assert filename in stdout