pre-commit/pre-commit-hooks
1
0
Fork 0
mirror of https://github.com/pre-commit/pre-commit-hooks.git synced 2026-04-01 02:56:52 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Refactor jinja usage

Browse source 
Moved out templates to root dir and start using only jinja template
instead of the complete Environment class. Requirements here are quite
simple.
This commit is contained in:
David Paz 2022-07-15 14:40:59 +02:00
parent ac248b5011
commit 51e5b74f80
No known key found for this signature in database
GPG key ID: 6600CC47B1C1B063
4 changed files with 21 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

23
pre_commit_hooks/prepare_commit_msg.py
View file

@ -4,12 +4,11 @@ import argparse
import re
from typing import Sequence
from jinja2 import Environment
from jinja2 import PackageLoader
from jinja2 import select_autoescape
from jinja2 import Template
from pre_commit_hooks.util import CalledProcessError
from pre_commit_hooks.util import cmd_output
from testing.util import get_template_path
def get_current_branch() -> str:
@ -25,7 +24,7 @@ def _configure_args(
parser: argparse.ArgumentParser,
) -> argparse.ArgumentParser:
parser.add_argument(
'-t', '--template', default='prepare_commit_msg_append.j2',
'-t', '--template', default=_get_default_template(),
help='Template to use for the commit message.',
)
parser.add_argument(
@ -42,24 +41,20 @@ def _configure_args(
return parser
def get_jinja_env() -> Environment:
return Environment(
loader=PackageLoader('pre_commit_hooks'),
autoescape=select_autoescape(),
)
def _get_default_template() -> str:
return get_template_path('prepare_commit_msg_append.j2')
def get_rendered_template(
jinja: Environment,
template_file: str,
variables: dict[str, str],
) -> str:
template = jinja.get_template(template_file)
with open(template_file) as f:
template = Template(f.read())
return template.render(variables)
def update_commit_file(
jinja: Environment,
commit_msg_file: str,
template: str,
ticket: str,
@ -81,7 +76,6 @@ def update_commit_file(
}
content = get_rendered_template(
jinja=jinja,
template_file=template,
variables=variables,
)
@ -114,9 +108,8 @@ def main(argv: Sequence[str] | None = None) -> int:
# checked white listed branches
return 0
jinja = get_jinja_env()
commit_file = args.COMMIT_MSG_FILE[0]
return update_commit_file(jinja, commit_file, args.template, matches[0])
return update_commit_file(commit_file, args.template, matches[0])
if __name__ == '__main__':