pre-commit/pre-commit-hooks
1
0
Fork 0
mirror of https://github.com/pre-commit/pre-commit-hooks.git synced 2026-03-29 10:16:52 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #450 from begoon/master

Browse source 
Skip empty key variables in detect_aws_credentials
This commit is contained in:
Anthony Sottile 2020-02-13 09:18:39 -08:00 • committed by GitHub
commit 45cb6a35b7
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
pre_commit_hooks/detect_aws_credentials.py
View file

@ -31,7 +31,7 @@ def get_aws_secrets_from_env() -> Set[str]:
for env_var in (
'AWS_SECRET_ACCESS_KEY', 'AWS_SECURITY_TOKEN', 'AWS_SESSION_TOKEN',
):
if env_var in os.environ:
if os.environ.get(env_var):
keys.add(os.environ[env_var])
return keys

2
tests/detect_aws_credentials_test.py
View file

@ -47,6 +47,8 @@ def test_get_aws_credentials_file_from_env(env_vars, values):
({'AWS_SECRET_ACCESS_KEY': 'foo'}, {'foo'}),
({'AWS_SECURITY_TOKEN': 'foo'}, {'foo'}),
({'AWS_SESSION_TOKEN': 'foo'}, {'foo'}),
({'AWS_SESSION_TOKEN': ''}, set()),
({'AWS_SESSION_TOKEN': 'foo', 'AWS_SECURITY_TOKEN': ''}, {'foo'}),
({'AWS_DUMMY_KEY': 'foo', 'AWS_SECRET_ACCESS_KEY': 'bar'}, {'bar'}),
(
{'AWS_SECRET_ACCESS_KEY': 'foo', 'AWS_SECURITY_TOKEN': 'bar'},