pre-commit/pre-commit-hooks
1
0
Fork 0
mirror of https://github.com/pre-commit/pre-commit-hooks.git synced 2026-06-29 06:00:45 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

[ISS-1258][DC] updating the detect_aws_credentials to support temp json files

Browse source
This commit is contained in:
DanielConnelly 2026-06-02 15:14:09 +01:00
parent fa6b006f0e
commit 10ce480836
No known key found for this signature in database
3 changed files with 70 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

17
tests/detect_aws_credentials_test.py
View file

@ -7,6 +7,7 @@ import pytest
from pre_commit_hooks.detect_aws_credentials import get_aws_cred_files_from_env
from pre_commit_hooks.detect_aws_credentials import get_aws_secrets_from_env
from pre_commit_hooks.detect_aws_credentials import get_aws_secrets_from_file
from pre_commit_hooks.detect_aws_credentials import get_aws_secrets_from_json_file
from pre_commit_hooks.detect_aws_credentials import main
from testing.util import get_resource_path
@ -67,6 +68,22 @@ def test_get_aws_secrets_from_env(env_vars, values):
with patch.dict('os.environ', env_vars, clear=True):
assert get_aws_secrets_from_env() == values
@pytest.mark.parametrize(
('filename', 'expected_keys'),
(
(
'aws_temp_secrets_file.json',
{"tempAccessKeyId", "tempSecretAccessKey", "tempSessionToken"},
),
('nonsense.txt', set()),
('ok_json.json', set()),
),
)
def test_get_aws_secrets_from_json_file(filename, expected_keys):
"""Test that reading secrets from files works."""
keys = get_aws_secrets_from_json_file(get_resource_path(filename))
assert keys == expected_keys
@pytest.mark.parametrize(
('filename', 'expected_keys'),