pre-commit/pre-commit-hooks
1
0
Fork 0
mirror of https://github.com/pre-commit/pre-commit-hooks.git synced 2026-03-30 02:16:52 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #236 from pre-commit/use_symlink_fixtures

Browse source 
Use fixtures for the symlink tests to fix appveyor
This commit is contained in:
Anthony Sottile 2017-09-08 08:43:19 -07:00 • committed by GitHub
commit 08a643e0de
3 changed files with 14 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

1
testing/resources/broken_symlink
View file

@ -1 +0,0 @@
does_not_exist

1
testing/resources/working_symlink
View file

@ -1 +0,0 @@
does_exist

23
tests/check_symlinks_test.py
View file

@ -3,16 +3,21 @@ import os
import pytest
from pre_commit_hooks.check_symlinks import check_symlinks
from testing.util import get_resource_path
@pytest.mark.xfail(os.name == 'nt', reason='No symlink support on windows')
xfail_symlink = pytest.mark.xfail(os.name == 'nt', reason='No symlink support')
@xfail_symlink
@pytest.mark.parametrize(
('filename', 'expected_retval'), (
('broken_symlink', 1),
('working_symlink', 0),
),
('dest', 'expected'), (('exists', 0), ('does-not-exist', 1)),
)
def test_check_symlinks(filename, expected_retval):
ret = check_symlinks([get_resource_path(filename)])
assert ret == expected_retval
def test_check_symlinks(tmpdir, dest, expected): # pragma: no cover (symlinks)
tmpdir.join('exists').ensure()
symlink = tmpdir.join('symlink')
symlink.mksymlinkto(tmpdir.join(dest))
assert check_symlinks((symlink.strpath,)) == expected
def test_check_symlinks_normal_file(tmpdir):
assert check_symlinks((tmpdir.join('f').ensure().strpath,)) == 0