mirror of
https://github.com/PyCQA/flake8.git
synced 2026-04-06 21:16:54 +00:00
31aad5975a
Leverage the `type` keyword argument to `ArgumentParser.add_option()` for converting the raw string, either from a configuration file or the command-line, into a data structure for later use. Now with `OptionManager.parse_args()` feeding configuration file values as default values to be considered by the `ArgumentParser.parse_args()` framework, normalization of the file paths occur in single place.
138 lines
3.8 KiB
Python
138 lines
3.8 KiB
Python
"""Integration tests for the main entrypoint of flake8."""
|
|
import json
|
|
import os
|
|
|
|
import mock
|
|
import pytest
|
|
|
|
from flake8 import utils
|
|
from flake8.main import cli
|
|
|
|
|
|
def _call_main(argv, retv=0):
|
|
with pytest.raises(SystemExit) as excinfo:
|
|
cli.main(argv)
|
|
assert excinfo.value.code == retv
|
|
|
|
|
|
def test_diff_option(tmpdir, capsys):
|
|
"""Ensure that `flake8 --diff` works."""
|
|
t_py_contents = '''\
|
|
import os
|
|
import sys # unused but not part of diff
|
|
|
|
print('(to avoid trailing whitespace in test)')
|
|
print('(to avoid trailing whitespace in test)')
|
|
print(os.path.join('foo', 'bar'))
|
|
|
|
y # part of the diff and an error
|
|
'''
|
|
|
|
diff = '''\
|
|
diff --git a/t.py b/t.py
|
|
index d64ac39..7d943de 100644
|
|
--- a/t.py
|
|
+++ b/t.py
|
|
@@ -4,3 +4,5 @@ import sys # unused but not part of diff
|
|
print('(to avoid trailing whitespace in test)')
|
|
print('(to avoid trailing whitespace in test)')
|
|
print(os.path.join('foo', 'bar'))
|
|
+
|
|
+y # part of the diff and an error
|
|
'''
|
|
|
|
with mock.patch.object(utils, 'stdin_get_value', return_value=diff):
|
|
with tmpdir.as_cwd():
|
|
tmpdir.join('t.py').write(t_py_contents)
|
|
_call_main(['--diff'], retv=1)
|
|
|
|
out, err = capsys.readouterr()
|
|
assert out == "t.py:8:1: F821 undefined name 'y'\n"
|
|
assert err == ''
|
|
|
|
|
|
def test_statistics_option(tmpdir, capsys):
|
|
"""Ensure that `flake8 --statistics` works."""
|
|
with tmpdir.as_cwd():
|
|
tmpdir.join('t.py').write('import os\nimport sys\n')
|
|
_call_main(['--statistics', 't.py'], retv=1)
|
|
|
|
out, err = capsys.readouterr()
|
|
assert out == '''\
|
|
t.py:1:1: F401 'os' imported but unused
|
|
t.py:2:1: F401 'sys' imported but unused
|
|
2 F401 'os' imported but unused
|
|
'''
|
|
assert err == ''
|
|
|
|
|
|
def test_extend_exclude(tmpdir, capsys):
|
|
"""Ensure that `flake8 --extend-exclude` works."""
|
|
for d in ['project', 'vendor', 'legacy', '.git', '.tox', '.hg']:
|
|
tmpdir.mkdir(d).join('t.py').write('import os\nimport sys\n')
|
|
|
|
with tmpdir.as_cwd():
|
|
_call_main(['--extend-exclude=vendor,legacy'], retv=1)
|
|
|
|
out, err = capsys.readouterr()
|
|
expected_out = '''\
|
|
./project/t.py:1:1: F401 'os' imported but unused
|
|
./project/t.py:2:1: F401 'sys' imported but unused
|
|
'''
|
|
assert out == expected_out.replace('/', os.sep)
|
|
assert err == ''
|
|
|
|
|
|
def test_malformed_per_file_ignores_error(tmpdir, capsys):
|
|
"""Test the error message for malformed `per-file-ignores`."""
|
|
setup_cfg = '''\
|
|
[flake8]
|
|
per-file-ignores =
|
|
incorrect/*
|
|
values/*
|
|
'''
|
|
|
|
with tmpdir.as_cwd():
|
|
tmpdir.join('setup.cfg').write(setup_cfg)
|
|
_call_main(['.'], retv=2)
|
|
|
|
out, err = capsys.readouterr()
|
|
assert err == '''\
|
|
usage: flake8 [options] file file ...
|
|
flake8: error: argument --per-file-ignores: Expected a mapping from file exclude patterns to ignore codes.
|
|
|
|
Found:
|
|
|
|
incorrect/*
|
|
values/*
|
|
''' # noqa: E501
|
|
|
|
|
|
def test_tokenization_error_but_not_syntax_error(tmpdir, capsys):
|
|
"""Test that flake8 does not crash on tokenization errors."""
|
|
with tmpdir.as_cwd():
|
|
# this is a crash in the tokenizer, but not in the ast
|
|
tmpdir.join('t.py').write("b'foo' \\\n")
|
|
_call_main(['t.py'], retv=1)
|
|
|
|
out, err = capsys.readouterr()
|
|
assert out == 't.py:1:1: E902 TokenError: EOF in multi-line statement\n'
|
|
assert err == ''
|
|
|
|
|
|
def test_bug_report_successful(capsys):
|
|
"""Test that --bug-report does not crash."""
|
|
_call_main(['--bug-report'])
|
|
out, err = capsys.readouterr()
|
|
assert json.loads(out)
|
|
assert err == ''
|
|
|
|
|
|
def test_obtaining_args_from_sys_argv_when_not_explicity_provided(capsys):
|
|
"""Test that arguments are obtained from 'sys.argv'."""
|
|
with mock.patch('sys.argv', ['flake8', '--help']):
|
|
_call_main(None)
|
|
|
|
out, err = capsys.readouterr()
|
|
assert out.startswith('usage: flake8 [options] file file ...\n')
|
|
assert err == ''
|