mirror of
https://github.com/PyCQA/flake8.git
synced 2026-04-07 05:26:53 +00:00
458 lines
17 KiB
Python
458 lines
17 KiB
Python
"""Option handling and Option management logic."""
|
|
import argparse
|
|
import collections
|
|
import contextlib
|
|
import functools
|
|
import logging
|
|
from typing import Any, Dict, Generator, List, Optional, Set, Union
|
|
|
|
from flake8 import utils
|
|
|
|
LOG = logging.getLogger(__name__)
|
|
|
|
_NOARG = object()
|
|
|
|
|
|
class _CallbackAction(argparse.Action):
|
|
"""Shim for optparse-style callback actions."""
|
|
|
|
def __init__(self, *args, **kwargs):
|
|
self._callback = kwargs.pop("callback")
|
|
self._callback_args = kwargs.pop("callback_args", ())
|
|
self._callback_kwargs = kwargs.pop("callback_kwargs", {})
|
|
super(_CallbackAction, self).__init__(*args, **kwargs)
|
|
|
|
def __call__(self, parser, namespace, values, option_string=None):
|
|
if not values:
|
|
values = None
|
|
elif isinstance(values, list) and len(values) > 1:
|
|
values = tuple(values)
|
|
self._callback(
|
|
self,
|
|
option_string,
|
|
values,
|
|
parser,
|
|
*self._callback_args,
|
|
**self._callback_kwargs
|
|
)
|
|
|
|
|
|
def _flake8_normalize(value, *args, **kwargs):
|
|
comma_separated_list = kwargs.pop("comma_separated_list", False)
|
|
normalize_paths = kwargs.pop("normalize_paths", False)
|
|
if kwargs:
|
|
raise TypeError("Unexpected keyword args: {}".format(kwargs))
|
|
|
|
if comma_separated_list and isinstance(value, utils.string_types):
|
|
value = utils.parse_comma_separated_list(value)
|
|
|
|
if normalize_paths:
|
|
if isinstance(value, list):
|
|
value = utils.normalize_paths(value, *args)
|
|
else:
|
|
value = utils.normalize_path(value, *args)
|
|
|
|
return value
|
|
|
|
|
|
class Option(object):
|
|
"""Our wrapper around an argparse argument parsers to add features."""
|
|
|
|
def __init__(
|
|
self,
|
|
short_option_name=_NOARG,
|
|
long_option_name=_NOARG,
|
|
# Options below here are taken from the optparse.Option class
|
|
action=_NOARG,
|
|
default=_NOARG,
|
|
type=_NOARG,
|
|
dest=_NOARG,
|
|
nargs=_NOARG,
|
|
const=_NOARG,
|
|
choices=_NOARG,
|
|
help=_NOARG,
|
|
metavar=_NOARG,
|
|
# deprecated optparse-only options
|
|
callback=_NOARG,
|
|
callback_args=_NOARG,
|
|
callback_kwargs=_NOARG,
|
|
# Options below are taken from argparse.ArgumentParser.add_argument
|
|
required=_NOARG,
|
|
# Options below here are specific to Flake8
|
|
parse_from_config=False,
|
|
comma_separated_list=False,
|
|
normalize_paths=False,
|
|
):
|
|
"""Initialize an Option instance.
|
|
|
|
The following are all passed directly through to argparse.
|
|
|
|
:param str short_option_name:
|
|
The short name of the option (e.g., ``-x``). This will be the
|
|
first argument passed to ``ArgumentParser.add_argument``
|
|
:param str long_option_name:
|
|
The long name of the option (e.g., ``--xtra-long-option``). This
|
|
will be the second argument passed to
|
|
``ArgumentParser.add_argument``
|
|
:param default:
|
|
Default value of the option.
|
|
:param dest:
|
|
Attribute name to store parsed option value as.
|
|
:param nargs:
|
|
Number of arguments to parse for this option.
|
|
:param const:
|
|
Constant value to store on a common destination. Usually used in
|
|
conjuntion with ``action="store_const"``.
|
|
:param iterable choices:
|
|
Possible values for the option.
|
|
:param str help:
|
|
Help text displayed in the usage information.
|
|
:param str metavar:
|
|
Name to use instead of the long option name for help text.
|
|
:param bool required:
|
|
Whether this option is required or not.
|
|
|
|
The following options may be passed directly through to :mod:`argparse`
|
|
but may need some massaging.
|
|
|
|
:param type:
|
|
A callable to normalize the type (as is the case in
|
|
:mod:`argparse`). Deprecated: you can also pass through type
|
|
strings such as ``'int'`` which are handled by :mod:`optparse`.
|
|
:param str action:
|
|
Any action allowed by :mod:`argparse`. Deprecated: this also
|
|
understands the ``action='callback'`` action from :mod:`optparse`.
|
|
:param callable callback:
|
|
Callback used if the action is ``"callback"``. Deprecated: please
|
|
use ``action=`` instead.
|
|
:param iterable callback_args:
|
|
Additional positional arguments to the callback callable.
|
|
Deprecated: please use ``action=`` instead (probably with
|
|
``functools.partial``).
|
|
:param dictionary callback_kwargs:
|
|
Keyword arguments to the callback callable. Deprecated: please
|
|
use ``action=`` instead (probably with ``functools.partial``).
|
|
|
|
The following parameters are for Flake8's option handling alone.
|
|
|
|
:param bool parse_from_config:
|
|
Whether or not this option should be parsed out of config files.
|
|
:param bool comma_separated_list:
|
|
Whether the option is a comma separated list when parsing from a
|
|
config file.
|
|
:param bool normalize_paths:
|
|
Whether the option is expecting a path or list of paths and should
|
|
attempt to normalize the paths to absolute paths.
|
|
"""
|
|
if long_option_name is _NOARG and short_option_name.startswith("--"):
|
|
short_option_name, long_option_name = _NOARG, short_option_name
|
|
|
|
# optparse -> argparse `%default` => `%(default)s`
|
|
if help is not _NOARG and "%default" in help:
|
|
LOG.warning(
|
|
"option %s: please update `help=` text to use %%(default)s "
|
|
"instead of %%default -- this will be an error in the future",
|
|
long_option_name,
|
|
)
|
|
help = help.replace("%default", "%(default)s")
|
|
|
|
# optparse -> argparse for `callback`
|
|
if action == "callback":
|
|
LOG.warning(
|
|
"option %s: please update from optparse `action='callback'` "
|
|
"to argparse action classes -- this will be an error in the "
|
|
"future",
|
|
long_option_name,
|
|
)
|
|
action = _CallbackAction
|
|
if type is _NOARG:
|
|
nargs = 0
|
|
|
|
# optparse -> argparse for `type`
|
|
if isinstance(type, utils.string_types):
|
|
LOG.warning(
|
|
"option %s: please update from optparse string `type=` to "
|
|
"argparse callable `type=` -- this will be an error in the "
|
|
"future"
|
|
)
|
|
type = {
|
|
"int": int,
|
|
"long": int,
|
|
"string": str,
|
|
"float": float,
|
|
"complex": complex,
|
|
"choice": _NOARG,
|
|
}[type]
|
|
|
|
# flake8 special type normalization
|
|
if comma_separated_list or normalize_paths:
|
|
type = functools.partial(
|
|
_flake8_normalize,
|
|
comma_separated_list=comma_separated_list,
|
|
normalize_paths=normalize_paths,
|
|
)
|
|
|
|
self.short_option_name = short_option_name
|
|
self.long_option_name = long_option_name
|
|
self.option_args = [
|
|
x
|
|
for x in (short_option_name, long_option_name)
|
|
if x is not _NOARG
|
|
]
|
|
self.option_kwargs = {
|
|
"action": action,
|
|
"default": default,
|
|
"type": type,
|
|
"dest": dest,
|
|
"nargs": nargs,
|
|
"const": const,
|
|
"choices": choices,
|
|
"callback": callback,
|
|
"callback_args": callback_args,
|
|
"callback_kwargs": callback_kwargs,
|
|
"help": help,
|
|
"metavar": metavar,
|
|
}
|
|
# Set attributes for our option arguments
|
|
for key, value in self.option_kwargs.items():
|
|
setattr(self, key, value)
|
|
|
|
# Set our custom attributes
|
|
self.parse_from_config = parse_from_config
|
|
self.comma_separated_list = comma_separated_list
|
|
self.normalize_paths = normalize_paths
|
|
|
|
self.config_name = None # type: Optional[str]
|
|
if parse_from_config:
|
|
if long_option_name is _NOARG:
|
|
raise ValueError(
|
|
"When specifying parse_from_config=True, "
|
|
"a long_option_name must also be specified."
|
|
)
|
|
self.config_name = long_option_name[2:].replace("-", "_")
|
|
|
|
self._opt = None
|
|
|
|
@property
|
|
def filtered_option_kwargs(self): # type: () -> Dict[str, Any]
|
|
"""Return any actually-specified arguments."""
|
|
return {
|
|
k: v for k, v in self.option_kwargs.items() if v is not _NOARG
|
|
}
|
|
|
|
def __repr__(self): # noqa: D105
|
|
parts = []
|
|
for arg in self.option_args:
|
|
parts.append(arg)
|
|
for k, v in self.filtered_option_kwargs.items():
|
|
parts.append("{}={!r}".format(k, v))
|
|
return "Option({})".format(", ".join(parts))
|
|
|
|
def normalize(self, value, *normalize_args):
|
|
"""Normalize the value based on the option configuration."""
|
|
if self.comma_separated_list and isinstance(
|
|
value, utils.string_types
|
|
):
|
|
value = utils.parse_comma_separated_list(value)
|
|
|
|
if self.normalize_paths:
|
|
if isinstance(value, list):
|
|
value = utils.normalize_paths(value, *normalize_args)
|
|
else:
|
|
value = utils.normalize_path(value, *normalize_args)
|
|
|
|
return value
|
|
|
|
def normalize_from_setuptools(self, value):
|
|
"""Normalize the value received from setuptools."""
|
|
value = self.normalize(value)
|
|
if self.type is int or self.action == "count":
|
|
return int(value)
|
|
elif self.type is float:
|
|
return float(value)
|
|
elif self.type is complex:
|
|
return complex(value)
|
|
if self.action in ("store_true", "store_false"):
|
|
value = str(value).upper()
|
|
if value in ("1", "T", "TRUE", "ON"):
|
|
return True
|
|
if value in ("0", "F", "FALSE", "OFF"):
|
|
return False
|
|
return value
|
|
|
|
def to_argparse(self):
|
|
"""Convert a Flake8 Option to argparse ``add_argument`` arguments."""
|
|
return self.option_args, self.filtered_option_kwargs
|
|
|
|
@property
|
|
def to_optparse(self):
|
|
"""No longer functional."""
|
|
raise AttributeError("to_optparse: flake8 now uses argparse")
|
|
|
|
|
|
PluginVersion = collections.namedtuple(
|
|
"PluginVersion", ["name", "version", "local"]
|
|
)
|
|
|
|
|
|
class OptionManager(object):
|
|
"""Manage Options and OptionParser while adding post-processing."""
|
|
|
|
def __init__(
|
|
self,
|
|
prog=None,
|
|
version=None,
|
|
usage="%(prog)s [options] file file ...",
|
|
):
|
|
"""Initialize an instance of an OptionManager.
|
|
|
|
:param str prog:
|
|
Name of the actual program (e.g., flake8).
|
|
:param str version:
|
|
Version string for the program.
|
|
:param str usage:
|
|
Basic usage string used by the OptionParser.
|
|
"""
|
|
self.parser = argparse.ArgumentParser(
|
|
prog=prog, usage=usage
|
|
) # type: Union[argparse.ArgumentParser, argparse._ArgumentGroup]
|
|
self.version_action = self.parser.add_argument(
|
|
"--version", action="version", version=version
|
|
)
|
|
self.parser.add_argument("filenames", nargs="*", metavar="filename")
|
|
self.config_options_dict = {} # type: Dict[str, Option]
|
|
self.options = [] # type: List[Option]
|
|
self.program_name = prog
|
|
self.version = version
|
|
self.registered_plugins = set() # type: Set[PluginVersion]
|
|
self.extended_default_ignore = set() # type: Set[str]
|
|
self.extended_default_select = set() # type: Set[str]
|
|
|
|
@staticmethod
|
|
def format_plugin(plugin):
|
|
"""Convert a PluginVersion into a dictionary mapping name to value."""
|
|
return {attr: getattr(plugin, attr) for attr in ["name", "version"]}
|
|
|
|
@contextlib.contextmanager
|
|
def group(self, name): # type: (str) -> Generator[None, None, None]
|
|
"""Attach options to an argparse group during this context."""
|
|
group = self.parser.add_argument_group(name)
|
|
self.parser, orig_parser = group, self.parser
|
|
try:
|
|
yield
|
|
finally:
|
|
self.parser = orig_parser
|
|
|
|
def add_option(self, *args, **kwargs):
|
|
"""Create and register a new option.
|
|
|
|
See parameters for :class:`~flake8.options.manager.Option` for
|
|
acceptable arguments to this method.
|
|
|
|
.. note::
|
|
|
|
``short_option_name`` and ``long_option_name`` may be specified
|
|
positionally as they are with argparse normally.
|
|
"""
|
|
option = Option(*args, **kwargs)
|
|
option_args, option_kwargs = option.to_argparse()
|
|
self.parser.add_argument(*option_args, **option_kwargs)
|
|
self.options.append(option)
|
|
if option.parse_from_config:
|
|
name = option.config_name
|
|
assert name is not None # nosec (for mypy)
|
|
self.config_options_dict[name] = option
|
|
self.config_options_dict[name.replace("_", "-")] = option
|
|
LOG.debug('Registered option "%s".', option)
|
|
|
|
def remove_from_default_ignore(self, error_codes):
|
|
"""Remove specified error codes from the default ignore list.
|
|
|
|
:param list error_codes:
|
|
List of strings that are the error/warning codes to attempt to
|
|
remove from the extended default ignore list.
|
|
"""
|
|
LOG.debug("Removing %r from the default ignore list", error_codes)
|
|
for error_code in error_codes:
|
|
try:
|
|
self.extended_default_ignore.remove(error_code)
|
|
except (ValueError, KeyError):
|
|
LOG.debug(
|
|
"Attempted to remove %s from default ignore"
|
|
" but it was not a member of the list.",
|
|
error_code,
|
|
)
|
|
|
|
def extend_default_ignore(self, error_codes):
|
|
"""Extend the default ignore list with the error codes provided.
|
|
|
|
:param list error_codes:
|
|
List of strings that are the error/warning codes with which to
|
|
extend the default ignore list.
|
|
"""
|
|
LOG.debug("Extending default ignore list with %r", error_codes)
|
|
self.extended_default_ignore.update(error_codes)
|
|
|
|
def extend_default_select(self, error_codes):
|
|
"""Extend the default select list with the error codes provided.
|
|
|
|
:param list error_codes:
|
|
List of strings that are the error/warning codes with which
|
|
to extend the default select list.
|
|
"""
|
|
LOG.debug("Extending default select list with %r", error_codes)
|
|
self.extended_default_select.update(error_codes)
|
|
|
|
def generate_versions(
|
|
self, format_str="%(name)s: %(version)s", join_on=", "
|
|
):
|
|
"""Generate a comma-separated list of versions of plugins."""
|
|
return join_on.join(
|
|
format_str % self.format_plugin(plugin)
|
|
for plugin in sorted(self.registered_plugins)
|
|
)
|
|
|
|
def update_version_string(self):
|
|
"""Update the flake8 version string."""
|
|
self.version_action.version = "{} ({}) {}".format(
|
|
self.version, self.generate_versions(), utils.get_python_version()
|
|
)
|
|
|
|
def generate_epilog(self):
|
|
"""Create an epilog with the version and name of each of plugin."""
|
|
plugin_version_format = "%(name)s: %(version)s"
|
|
self.parser.epilog = "Installed plugins: " + self.generate_versions(
|
|
plugin_version_format
|
|
)
|
|
|
|
def parse_args(self, args=None, values=None):
|
|
"""Proxy to calling the OptionParser's parse_args method."""
|
|
self.generate_epilog()
|
|
self.update_version_string()
|
|
args = self.parser.parse_args(args, values)
|
|
# TODO: refactor callers to not need this
|
|
return args, args.filenames
|
|
|
|
def parse_known_args(self, args=None):
|
|
"""Parse only the known arguments from the argument values.
|
|
|
|
Replicate a little argparse behaviour while we're still on
|
|
optparse.
|
|
"""
|
|
self.generate_epilog()
|
|
self.update_version_string()
|
|
args, rest = self.parser.parse_known_args(args)
|
|
return args, rest
|
|
|
|
def register_plugin(self, name, version, local=False):
|
|
"""Register a plugin relying on the OptionManager.
|
|
|
|
:param str name:
|
|
The name of the checker itself. This will be the ``name``
|
|
attribute of the class or function loaded from the entry-point.
|
|
:param str version:
|
|
The version of the checker that we're using.
|
|
:param bool local:
|
|
Whether the plugin is local to the project/repository or not.
|
|
"""
|
|
self.registered_plugins.add(PluginVersion(name, version, local))
|