This change was originally triggered by @gvanrossum requeesting
that pep8 (the tool) be renamed to avoid confusion with PEP-8
the document. This request is tracked at:
https://github.com/PyCQA/pycodestyle/issues/466
Previously, we passed the location for our user config file to the
StyleGuide. This was intended to be a way to tell pep8's StyleGuide
to use that as a user config file, but instead that became the default
for the --config command-line option. This caused that to have higher
priority than the project configuration file.
Closes#122
Right now, running the git and hg commands could easily raise an
OSError. Let's only catch it in those cases and then use else to
install hooks when those are successful. Otherwise, pass on to the next
supported VCS
When ignore is an empty string, it will apparently not run any checks at
all. Using None as the default ensures that it does run the appropriate
checks.
Closes#52
os.path.relpath on Python 2.6 returns slightly different output than it
does on 2.7. Rather than try to write tests around the behaviour, it
makes sense to have a common relpath function that behaves the same on
every version.
The simpler fix is to ensure that the filename isn't the full path to
the temporary file before we check to see if it should be excluded or if
it should even match.
This also fixes a bug I found while testing the pull request in which no
files are checked.
In a config file, a user can use the "filename" option to specify
a pattern for matching filenames. The git hook effectively ignores
this and only checks files ending in '.py'
Instead of setting parse_argv to True, which fails if no config files
are present, we pass the current directory as the paths keyword
argument when creating the pep8 StyleGuide. This causes pep8 to parse
local config files as expected and works also if none are present.
Requires pep8 68d72a5d or newer.
Setting it to None is interpreted as the string 'None', which does the
wrong thing. Setting it to the empty string gives the right behaviour
and allows overriding in config files.
Non python files were being included in the git hook. Also, I realized that
with --install-hook on git projects, the file was not readable to the user.
Using binary helps clarify the use of chmod since I had erroneously used the
744 like the commandline does.
