Commit graph

54 commits

Author SHA1 Message Date
Ian Cordasco
de9f56addf Fix import ordering in test files 2016-02-25 14:41:37 -06:00
Ian Cordasco
a4e984dbd2 Add and fix documentation
- Add more documentation around utils functions
- Fix documentation about default formatting plugins
- Add extra documentation of filenames_from predicate parameter
- Add test for the default parameter of flake8.utils.fnmatch
2016-02-25 09:06:50 -06:00
Ian Cordasco
24d2689a05 Distinguish check types via plugin type manager
Flake8 and pep8 has historically supported three types of checks:

- Plugins that accept the physical line
- Plugins that accept the logical line
- Plugins that accept the AST tree

The logical place to make this distinction is on the Checkers plugin
type manager class. This adds the foundation for finding plugins that
fall into each class.
2016-02-23 23:20:34 -06:00
Ian Cordasco
5ee061b810 Add line splitting and file reading
Add some tests around reading lines and striping UTF BOMs
2016-02-23 11:17:11 -06:00
Ian Cordasco
8792c30872 Add utility functions around filename matching
We add utils.fnmatch and utils.filenames_for in anticipation of our
checker manager creating file checkers for each file. We also include
tests for these functions and a couple previously untested utility
functions.
2016-02-22 21:47:43 -06:00
Ian Cordasco
98357e71db Fix Notifier.listeners_for
If no Trie.find returns None, then node.data will return an
AttributeError.
2016-02-19 18:55:01 -06:00
Ian Cordasco
58b2ca69e4 Remove arguments from StyleGuide
- StyleGuides do not need the arguments passed in
- Add a test for is_inline_ignored obeying disable_noqa
2016-02-19 16:10:38 -06:00
Ian Cordasco
6d3d955ba9 Fix other tests after pylint fixes 2016-02-19 16:10:00 -06:00
Ian Cordasco
69b8be71dc Make pylint happier 2016-02-19 15:10:46 -06:00
Ian Cordasco
fbd5944f15 Add specific tests for is_inline_ignored
Update the logic so someone can use a class in their ``# noqa`` ignore
list
2016-02-19 11:02:22 -06:00
Ian Cordasco
f4b18229a0 Add checking for inline #noqa comments
This also supports ignoring only specified codes
2016-02-19 09:08:24 -06:00
Ian Cordasco
a9a939cbbc Update StyleGuide tests and add new tests for handle_error 2016-02-15 22:31:56 -06:00
Ian Cordasco
eafc91ae6a Add handling and decision making for select and ignore 2016-02-02 20:48:26 -06:00
Ian Cordasco
0645ec3ef7 Move __contains__ and __getitem__ to proper class 2016-02-02 16:53:24 -06:00
Ian Cordasco
5dc7440a2b Start documenting our Trie implementation 2016-02-01 20:09:15 -06:00
Ian Cordasco
2cba89c568 Log extended default values and add a test 2016-01-24 22:14:21 -06:00
Ian Cordasco
ebdc935ffc Refactor NotifierBuilder into its own mixin
This allows for easier unit testing
2016-01-24 15:13:58 -06:00
Ian Cordasco
b0a258fe79 Refactor our PluginTypeManager tests
Add tests for PluginTypeManager#{register,provide}_optoins
2016-01-23 23:02:06 -06:00
Ian Cordasco
6e8e2b9669 Write more PluginTypeManager tests 2016-01-22 09:06:24 -06:00
Ian Cordasco
3b64ff2a1f Make Plugin.load_plugin raise a Flake8 exception
Let's catch exceptions, log them, and re-raise as a FailedToLoad
exception. This also refactors the actually loading of plugins into a
private method on the Plugin class.
2016-01-22 09:04:52 -06:00
Ian Cordasco
6546cf41d4 Add tests for the PluginTypeManager 2016-01-21 22:15:38 -06:00
Ian Cordasco
916bec859c Finish testing PluginManager 2016-01-21 08:32:35 -06:00
Ian Cordasco
50e8fef125 Add more PluginManager tests 2016-01-21 08:26:05 -06:00
Ian Cordasco
6a72e36681 Start tests for PluginManager 2016-01-19 23:01:07 -06:00
Ian Cordasco
56a75cc391 Add tests for the Plugin class 2016-01-19 22:57:04 -06:00
Ian Cordasco
dcf696d678 Add tests around new OptionManager methods 2016-01-17 21:45:32 -06:00
Ian Cordasco
cb9231eb9b Add tests around merge_user_and_local_config and parse 2016-01-10 22:07:30 -06:00
Ian Cordasco
e5c3ae5cd2 Add tests for parse_{user,local}_config methods 2016-01-10 21:43:00 -06:00
Ian Cordasco
18bfa1f8a2 Add test for is_configured_by 2016-01-10 15:20:08 -06:00
Ian Cordasco
8c872c4bb9 Add more docstrings and fix lint errors 2016-01-10 14:47:06 -06:00
Ian Cordasco
5903576732 Ignore only D203 and fix Flake8 errors 2016-01-10 14:36:52 -06:00
Ian Cordasco
a8576aff12 Fix bugs found while writing parse_cli_config test 2016-01-10 13:22:18 -06:00
Ian Cordasco
66da9160b4 Start testing MergedConfigParser
Rename the GETINT/GETBOOL sets on the MergedConfigParser to use better
names.
2016-01-10 13:05:35 -06:00
Ian Cordasco
8b85e93e21 Add test for local_configs method 2016-01-10 12:52:29 -06:00
Ian Cordasco
de96b24bad Add parameter for missing extra config file 2016-01-10 09:50:32 -06:00
Ian Cordasco
7269d84845 Add test parameters with extra_config_files 2016-01-10 09:45:43 -06:00
Ian Cordasco
b8dfc9a8e2 Start testing ConfigFileFinder.local_config_files
Make sure extra_config_files are all absolute paths and filter them
in local_config_files to ensure they exist.
2016-01-10 09:39:37 -06:00
Ian Cordasco
204a367095 Add more parameters to file location generation test 2016-01-10 09:05:09 -06:00
Ian Cordasco
cb276d63e3 Parametrize windows detection unit test 2016-01-10 09:04:39 -06:00
Ian Cordasco
949d3e48fe Add tests for generate_possible_local_config_files
Fix a bug found via testing where we traverse all the way to the root
directory looking for config files.
2016-01-10 08:40:35 -06:00
Ian Cordasco
dd46f02b58 Add config file fixtures
Add more ConfigFileFinder tests
2016-01-09 23:02:20 -06:00
Ian Cordasco
8dd160c98e Start writing tests for the config finder 2016-01-09 22:34:39 -06:00
Ian Cordasco
9fe9ef06f7 Add test for comma-separated paths normalization 2016-01-09 21:20:20 -06:00
Ian Cordasco
cc3a9210fd Add more tests around parse_args 2016-01-09 21:15:03 -06:00
Ian Cordasco
ec26d46dff Add tests for normalize_path and normalize_paths 2016-01-09 21:04:11 -06:00
Ian Cordasco
13ca3dfe37 Show that even defaults are properly normalized 2016-01-09 20:30:28 -06:00
Ian Cordasco
a7f7bbbeb2 Handle when dest is provided to Option 2016-01-09 20:29:09 -06:00
Ian Cordasco
a4042d6d69 Start fleshing out flake8.utils
Add parse_comma_separated_list, normalize_path, and normalize_paths and
add logic in OptionManager.parse_args to use the right normalize_path*
function based on comma_separated_list value of the option.
2016-01-09 15:58:26 -06:00
Ian Cordasco
ad0200e792 Add failing test for OptionManager.parse_args 2016-01-09 15:33:01 -06:00
Ian Cordasco
36cc254542 Generate dest for Options always 2016-01-09 15:32:44 -06:00