pre-commit/flake8
1
0
Fork 0
mirror of https://github.com/PyCQA/flake8.git synced 2026-04-05 12:36:54 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

options: Forward --output-file to be reparsed for BaseFormatter

Browse source 
This fixes a regression introduced in daca2c8 and b14d47b.

The --output-file` option was consumed by the preliminary option parser.
However, the `BaseFormatter` class needs the option for setting the
output filename.  This special cases this option to ensure it gets
re-parsed and respected when specified on the CLI.
This commit is contained in:
Eric N. Vander Weele 2020-05-11 23:43:39 -04:00 • committed by Anthony Sottile
parent b4d2850192
commit e6d8a90e5d
2 changed files with 20 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/flake8/main/application.py
View file

@ -112,7 +112,12 @@ class Application(object):
:rtype:
(argparse.Namespace, list)
"""
return self.prelim_arg_parser.parse_known_args(argv)
args, rest = self.prelim_arg_parser.parse_known_args(argv)
# XXX (ericvw): Special case "forwarding" the output file option so
# that it can be reparsed again for the BaseFormatter.filename.
if args.output_file:
rest.extend(("--output-file", args.output_file))
return args, rest
def exit(self):
# type: () -> None