pre-commit/flake8
1
0
Fork 0
mirror of https://github.com/PyCQA/flake8.git synced 2026-04-05 04:36:52 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix handling of logical lines with noqa

Browse source 
When attempting to centralize all inline NoQA handling in the StyleGuide
we inadvertently broke plugins relying on it in combination with checker
state. For example, the check for E402 relies both on NoQA and the state
to determine if it has seen a non-import line. Placing NoQA on the sole
line that is not an import is more elegant than placing it on each of
the following import lines.

Closes #186
This commit is contained in:
Ian Cordasco 2016-07-26 19:41:41 -05:00
parent 6eca38f2f2
commit e51fc5458b
No known key found for this signature in database
GPG key ID: 656D3395E4A9791A
5 changed files with 33 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

5
docs/source/release-notes/3.0.2.rst
View file

@ -6,7 +6,12 @@
- Fix indexing of column numbers. We accidentally were starting column indices
at 0 instead of 1.
- Fix regression in handling of errors like E402 that rely on a combination of
attributes. (See also `GitLab#186`_)
.. links
.. _GitLab#181:
https://gitlab.com/pycqa/flake8/issues/181
.. _GitLab#186:
https://gitlab.com/pycqa/flake8/issues/186