pre-commit/flake8
1
0
Fork 0
mirror of https://github.com/PyCQA/flake8.git synced 2026-04-11 07:14:18 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Prefer .flake8 if present for options.

Browse source 
If somebody explicitly has a `.flake8` file, presumably they intend to
put flake8 configuration in it, so prefer it to the generic `setup.cfg`
and `tox.ini` from pycodestyle.
This commit is contained in:
Tom Prince 2016-06-21 08:57:52 -06:00
parent 00575214db
commit db9d4ad8b4
2 changed files with 20 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/flake8/options/config.py
View file

@ -41,7 +41,9 @@ class ConfigFileFinder(object):
self.program_name = program_name self.program_name = program_name
# List of filenames to find in the local/project directory # List of filenames to find in the local/project directory
self.project_filenames = ('setup.cfg', 'tox.ini', self.program_config) self.project_filenames = (
self.program_config,
) + self.PROJECT_FILENAMES
self.local_directory = os.path.abspath(os.curdir) self.local_directory = os.path.abspath(os.curdir)

34
tests/unit/test_config_file_finder.py
View file

@ -42,28 +42,28 @@ def test_cli_config():
@pytest.mark.parametrize('args,expected', [ @pytest.mark.parametrize('args,expected', [
# No arguments, common prefix of abspath('.') # No arguments, common prefix of abspath('.')
([], ([],
[os.path.abspath('setup.cfg'), [os.path.abspath('.flake8'),
os.path.abspath('tox.ini'), os.path.abspath('setup.cfg'),
os.path.abspath('.flake8')]), os.path.abspath('tox.ini')]),
# Common prefix of "flake8/" # Common prefix of "flake8/"
(['flake8/options', 'flake8/'], (['flake8/options', 'flake8/'],
[os.path.abspath('flake8/setup.cfg'), [os.path.abspath('flake8/.flake8'),
os.path.abspath('flake8/tox.ini'),
os.path.abspath('flake8/.flake8'),
os.path.abspath('setup.cfg'),
os.path.abspath('tox.ini'),
os.path.abspath('.flake8')]),
# Common prefix of "flake8/options"
(['flake8/options', 'flake8/options/sub'],
[os.path.abspath('flake8/options/setup.cfg'),
os.path.abspath('flake8/options/tox.ini'),
os.path.abspath('flake8/options/.flake8'),
os.path.abspath('flake8/setup.cfg'), os.path.abspath('flake8/setup.cfg'),
os.path.abspath('flake8/tox.ini'), os.path.abspath('flake8/tox.ini'),
os.path.abspath('flake8/.flake8'), os.path.abspath('.flake8'),
os.path.abspath('setup.cfg'), os.path.abspath('setup.cfg'),
os.path.abspath('tox.ini'), os.path.abspath('tox.ini')]),
os.path.abspath('.flake8')]), # Common prefix of "flake8/options"
(['flake8/options', 'flake8/options/sub'],
[os.path.abspath('flake8/options/.flake8'),
os.path.abspath('flake8/options/setup.cfg'),
os.path.abspath('flake8/options/tox.ini'),
os.path.abspath('flake8/.flake8'),
os.path.abspath('flake8/setup.cfg'),
os.path.abspath('flake8/tox.ini'),
os.path.abspath('.flake8'),
os.path.abspath('setup.cfg'),
os.path.abspath('tox.ini')]),
]) ])
def test_generate_possible_local_files(args, expected): def test_generate_possible_local_files(args, expected):
"""Verify generation of all possible config paths.""" """Verify generation of all possible config paths."""