From c2216c0ddfea7f981670eff06ba1b832f1fd2f69 Mon Sep 17 00:00:00 2001 From: "Eric N. Vander Weele" Date: Thu, 29 Aug 2019 16:34:30 -0400 Subject: [PATCH] Add typings to ConfigFileFinder constructor `OptionManager.parse_known_args()` is guaranteed to return a list of remaining argument strings. --- src/flake8/options/config.py | 1 + tests/unit/test_config_file_finder.py | 12 ++++++------ 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/src/flake8/options/config.py b/src/flake8/options/config.py index 0a43625..9f3235d 100644 --- a/src/flake8/options/config.py +++ b/src/flake8/options/config.py @@ -17,6 +17,7 @@ class ConfigFileFinder(object): """Encapsulate the logic for finding and reading config files.""" def __init__(self, program_name, args, extra_config_files): + # type: (str, List[str], List[str]) -> None """Initialize object to find config files. :param str program_name: diff --git a/tests/unit/test_config_file_finder.py b/tests/unit/test_config_file_finder.py index f0f863d..c51e1f2 100644 --- a/tests/unit/test_config_file_finder.py +++ b/tests/unit/test_config_file_finder.py @@ -15,7 +15,7 @@ BROKEN_CONFIG_PATH = 'tests/fixtures/config_files/broken.ini' def test_uses_default_args(): """Show that we default the args value.""" - finder = config.ConfigFileFinder('flake8', None, []) + finder = config.ConfigFileFinder('flake8', [], []) assert finder.parent == os.path.abspath('.') @@ -27,14 +27,14 @@ def test_uses_default_args(): def test_windows_detection(platform, is_windows): """Verify we detect Windows to the best of our knowledge.""" with mock.patch.object(sys, 'platform', platform): - finder = config.ConfigFileFinder('flake8', None, []) + finder = config.ConfigFileFinder('flake8', [], []) assert finder.is_windows is is_windows def test_cli_config(): """Verify opening and reading the file specified via the cli.""" cli_filepath = CLI_SPECIFIED_FILEPATH - finder = config.ConfigFileFinder('flake8', None, []) + finder = config.ConfigFileFinder('flake8', [], []) parsed_config = finder.cli_config(cli_filepath) assert parsed_config.has_section('flake8') @@ -42,7 +42,7 @@ def test_cli_config(): def test_cli_config_double_read(): """Second request for CLI config is cached.""" - finder = config.ConfigFileFinder('flake8', None, []) + finder = config.ConfigFileFinder('flake8', [], []) parsed_config = finder.cli_config(CLI_SPECIFIED_FILEPATH) boom = Exception("second request for CLI config not cached") @@ -113,14 +113,14 @@ def test_local_config_files(args, extra_config_files, expected): def test_local_configs(): """Verify we return a ConfigParser.""" - finder = config.ConfigFileFinder('flake8', None, []) + finder = config.ConfigFileFinder('flake8', [], []) assert isinstance(finder.local_configs(), configparser.RawConfigParser) def test_local_configs_double_read(): """Second request for local configs is cached.""" - finder = config.ConfigFileFinder('flake8', None, []) + finder = config.ConfigFileFinder('flake8', [], []) first_read = finder.local_configs() boom = Exception("second request for local configs not cached")