pre-commit/flake8
1
0
Fork 0
mirror of https://github.com/PyCQA/flake8.git synced 2026-04-08 22:04:17 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

move managing of off_by_default / enable_extensions to plugin loading

Browse source
This commit is contained in:
Anthony Sottile 2022-01-01 18:28:11 -05:00
parent ff13916d74
commit a8333e2bf2
12 changed files with 137 additions and 111 deletions
Download patch file Download diff file Expand all files Collapse all files

100
tests/unit/test_decision_engine.py
View file

@ -16,7 +16,6 @@ def create_options(**kwargs):
kwargs.setdefault("ignore", [])
kwargs.setdefault("extend_ignore", [])
kwargs.setdefault("disable_noqa", False)
kwargs.setdefault("enable_extensions", [])
return argparse.Namespace(**kwargs)
@ -64,30 +63,25 @@ def test_was_ignored_implicitly_selects_errors(
@pytest.mark.parametrize(
"select_list,extend_select,enable_extensions,error_code",
[
(["E111", "E121"], [], [], "E111"),
(["E111", "E121"], [], [], "E121"),
(["E11", "E12"], [], [], "E121"),
(["E2", "E12"], [], [], "E121"),
(["E2", "E12"], [], [], "E211"),
(["E1"], ["E2"], [], "E211"),
(["E1"], [], ["E2"], "E211"),
([], ["E2"], [], "E211"),
([], [], ["E2"], "E211"),
(["E1"], ["E2"], [], "E211"),
(["E111"], ["E121"], ["E2"], "E121"),
],
("select_list", "extend_select", "error_code"),
(
(["E111", "E121"], [], "E111"),
(["E111", "E121"], [], "E121"),
(["E11", "E12"], [], "E121"),
(["E2", "E12"], [], "E121"),
(["E2", "E12"], [], "E211"),
(["E1"], ["E2"], "E211"),
([], ["E2"], "E211"),
(["E1"], ["E2"], "E211"),
(["E111"], ["E121"], "E121"),
),
)
def test_was_selected_selects_errors(
select_list, extend_select, enable_extensions, error_code
):
def test_was_selected_selects_errors(select_list, extend_select, error_code):
"""Verify we detect users explicitly selecting an error."""
decider = style_guide.DecisionEngine(
options=create_options(
select=select_list,
extend_select=extend_select,
enable_extensions=enable_extensions,
),
)
@ -199,15 +193,20 @@ def test_decision_for(
@pytest.mark.parametrize(
"select,ignore,extended_default_ignore,extended_default_select,"
"enabled_extensions,error_code,expected",
(
"select",
"ignore",
"extended_default_ignore",
"extended_default_select",
"error_code",
"expected",
),
[
(
defaults.SELECT,
[],
[],
["I1"],
[],
"I100",
style_guide.Decision.Selected,
),
@ -216,7 +215,6 @@ def test_decision_for(
[],
[],
["I1"],
[],
"I201",
style_guide.Decision.Ignored,
),
@ -225,7 +223,6 @@ def test_decision_for(
["I2"],
[],
["I1"],
[],
"I101",
style_guide.Decision.Selected,
),
@ -234,7 +231,6 @@ def test_decision_for(
["I2"],
[],
["I1"],
[],
"I201",
style_guide.Decision.Ignored,
),
@ -243,7 +239,6 @@ def test_decision_for(
["I1"],
[],
["I10"],
[],
"I101",
style_guide.Decision.Selected,
),
@ -252,43 +247,22 @@ def test_decision_for(
["I10"],
[],
["I1"],
[],
"I101",
style_guide.Decision.Ignored,
),
(
defaults.SELECT,
[],
[],
[],
["U4"],
"U401",
style_guide.Decision.Selected,
),
(
defaults.SELECT,
["U401"],
[],
[],
["U4"],
"U401",
style_guide.Decision.Ignored,
),
(
defaults.SELECT,
["U401"],
[],
[],
["U4"],
"U402",
style_guide.Decision.Selected,
),
(
["E", "W"],
["E13"],
[],
[],
[],
"E131",
style_guide.Decision.Ignored,
),
@ -297,18 +271,16 @@ def test_decision_for(
["E13"],
[],
[],
[],
"E126",
style_guide.Decision.Selected,
),
(["E2"], ["E21"], [], [], [], "E221", style_guide.Decision.Selected),
(["E2"], ["E21"], [], [], [], "E212", style_guide.Decision.Ignored),
(["E2"], ["E21"], [], [], "E221", style_guide.Decision.Selected),
(["E2"], ["E21"], [], [], "E212", style_guide.Decision.Ignored),
(
["F", "W"],
["C90"],
[],
["I1"],
[],
"C901",
style_guide.Decision.Ignored,
),
@ -317,25 +289,14 @@ def test_decision_for(
["C"],
[],
[],
[],
"E131",
style_guide.Decision.Selected,
),
(
defaults.SELECT,
defaults.IGNORE,
[],
[],
["I"],
"I101",
style_guide.Decision.Selected,
),
(
defaults.SELECT,
defaults.IGNORE,
[],
["G"],
["I"],
"G101",
style_guide.Decision.Selected,
),
@ -344,25 +305,14 @@ def test_decision_for(
["G1"],
[],
["G"],
["I"],
"G101",
style_guide.Decision.Ignored,
),
(
defaults.SELECT,
["E126"],
[],
[],
["I"],
"I101",
style_guide.Decision.Selected,
),
(
["E", "W"],
defaults.IGNORE,
[],
["I"],
[],
"I101",
style_guide.Decision.Ignored,
),
@ -371,7 +321,6 @@ def test_decision_for(
defaults.IGNORE + ("I101",),
["I101"],
[],
[],
"I101",
style_guide.Decision.Selected,
),
@ -380,7 +329,6 @@ def test_decision_for(
defaults.IGNORE + ("I101",),
["I101"],
[],
[],
"I101",
style_guide.Decision.Ignored,
),
@ -393,7 +341,6 @@ def test_more_specific_decision_for_logic(
ignore,
extended_default_ignore,
extended_default_select,
enabled_extensions,
error_code,
expected,
):
@ -404,7 +351,6 @@ def test_more_specific_decision_for_logic(
ignore=ignore,
extended_default_select=extended_default_select,
extended_default_ignore=extended_default_ignore,
enable_extensions=enabled_extensions,
),
)