pre-commit/flake8
1
0
Fork 0
mirror of https://github.com/PyCQA/flake8.git synced 2026-04-11 07:14:18 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Support spaces as error/ignore code separators

Browse source 
Closes #329
This commit is contained in:
Ian Cordasco 2017-05-25 20:02:58 -05:00
parent a36d44a70d
commit a42299d008
No known key found for this signature in database
GPG key ID: 656D3395E4A9791A
2 changed files with 7 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/flake8/utils.py
View file

@ -10,6 +10,7 @@ import sys
import tokenize import tokenize
DIFF_HUNK_REGEXP = re.compile(r'^@@ -\d+(?:,\d+)? \+(\d+)(?:,(\d+))? @@.*$') DIFF_HUNK_REGEXP = re.compile(r'^@@ -\d+(?:,\d+)? \+(\d+)(?:,(\d+))? @@.*$')
COMMA_SEPARATED_LIST_RE = re.compile(r'[,\s]')
def parse_comma_separated_list(value): def parse_comma_separated_list(value):
@ -27,7 +28,7 @@ def parse_comma_separated_list(value):
return [] return []
if not isinstance(value, (list, tuple)): if not isinstance(value, (list, tuple)):
value = value.split(',') value = COMMA_SEPARATED_LIST_RE.split(value)
item_gen = (item.strip() for item in value) item_gen = (item.strip() for item in value)
return [item for item in item_gen if item] return [item for item in item_gen if item]

5
tests/unit/test_utils.py
View file

@ -13,13 +13,18 @@ RELATIVE_PATHS = ["flake8", "pep8", "pyflakes", "mccabe"]
@pytest.mark.parametrize("value,expected", [ @pytest.mark.parametrize("value,expected", [
("E123,\n\tW234,\n E206", ["E123", "W234", "E206"]), ("E123,\n\tW234,\n E206", ["E123", "W234", "E206"]),
("E123,W234,E206", ["E123", "W234", "E206"]), ("E123,W234,E206", ["E123", "W234", "E206"]),
("E123 W234 E206", ["E123", "W234", "E206"]),
("E123\nW234 E206", ["E123", "W234", "E206"]),
("E123\nW234\nE206", ["E123", "W234", "E206"]),
("E123,W234,E206,", ["E123", "W234", "E206"]), ("E123,W234,E206,", ["E123", "W234", "E206"]),
("E123,W234,E206, ,\n", ["E123", "W234", "E206"]),
("E123,W234,,E206,,", ["E123", "W234", "E206"]), ("E123,W234,,E206,,", ["E123", "W234", "E206"]),
("E123,,W234,,E206,,", ["E123", "W234", "E206"]), ("E123,,W234,,E206,,", ["E123", "W234", "E206"]),
(["E123", "W234", "E206"], ["E123", "W234", "E206"]), (["E123", "W234", "E206"], ["E123", "W234", "E206"]),
(["E123", "\n\tW234", "\n E206"], ["E123", "W234", "E206"]), (["E123", "\n\tW234", "\n E206"], ["E123", "W234", "E206"]),
(["E123", "\n\tW234", "\n E206", "\n"], ["E123", "W234", "E206"]), (["E123", "\n\tW234", "\n E206", "\n"], ["E123", "W234", "E206"]),
(["E123", "\n\tW234", "", "\n E206", "\n"], ["E123", "W234", "E206"]), (["E123", "\n\tW234", "", "\n E206", "\n"], ["E123", "W234", "E206"]),
(["E123", "\n\tW234", "", "\n E206", ""], ["E123", "W234", "E206"]),
]) ])
def test_parse_comma_separated_list(value, expected): def test_parse_comma_separated_list(value, expected):
"""Verify that similar inputs produce identical outputs.""" """Verify that similar inputs produce identical outputs."""