pre-commit/flake8
1
0
Fork 0
mirror of https://github.com/PyCQA/flake8.git synced 2026-04-09 22:34:17 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge branch 'specific_noqa_pycodestyle' into 'master'

Browse source 
Do not pass `noqa` to plugins, have flake8 decide whether to report

Closes #552

See merge request pycqa/flake8!331
This commit is contained in:
Anthony Sottile 2019-10-28 16:51:09 +00:00
commit 7441c63de8
2 changed files with 15 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

12
tests/integration/test_main.py
View file

@ -147,6 +147,18 @@ def test_bug_report_successful(capsys):
assert err == ''
def test_specific_noqa_does_not_clobber_pycodestyle_noqa(tmpdir, capsys):
"""See https://gitlab.com/pycqa/flake8/issues/552."""
with tmpdir.as_cwd():
tmpdir.join('t.py').write("test = ('ABC' == None) # noqa: E501\n")
_call_main(['t.py'], retv=1)
out, err = capsys.readouterr()
assert out == '''\
t.py:1:15: E711 comparison to None should be 'if cond is None:'
'''
def test_obtaining_args_from_sys_argv_when_not_explicity_provided(capsys):
"""Test that arguments are obtained from 'sys.argv'."""
with mock.patch('sys.argv', ['flake8', '--help']):