pre-commit/flake8
1
0
Fork 0
mirror of https://github.com/PyCQA/flake8.git synced 2026-04-05 12:36:54 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix zero-indexed column numbering

Browse source 
We accidentally changed column numbering from one-indexed to
zero-indexed.
This commit is contained in:
Ian Cordasco 2016-07-26 19:15:08 -05:00
parent ec6165e9d8
commit 6eca38f2f2
No known key found for this signature in database
GPG key ID: 656D3395E4A9791A
5 changed files with 11 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/flake8/formatting/base.py
View file

@ -139,7 +139,9 @@ class BaseFormatter(object):
if not self.options.show_source or error.physical_line is None:
return ''
pointer = (' ' * error.column_number) + '^'
# Because column numbers are 1-indexed, we need to remove one to get
# the proper number of space characters.
pointer = (' ' * (error.column_number - 1)) + '^'
# Physical lines have a newline at the end, no need to add an extra
# one
return error.physical_line + pointer

4
src/flake8/style_guide.py
View file

@ -258,7 +258,9 @@ class StyleGuide(object):
:rtype:
int
"""
error = Error(code, filename, line_number, column_number, text,
# NOTE(sigmavirus24): Apparently we're provided with 0-indexed column
# numbers so we have to offset that here.
error = Error(code, filename, line_number, column_number + 1, text,
physical_line)
error_is_selected = (self.should_report_error(error.code) is
Decision.Selected)