pre-commit/flake8
1
0
Fork 0
mirror of https://github.com/PyCQA/flake8.git synced 2026-04-06 21:16:54 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Rename methods on the new DecisionEngine

Browse source 
Rename `decision_for` to `more_specific_decision_for` and
`should_report_error` to `decision_for`.
This commit is contained in:
Ian Cordasco 2017-06-03 19:20:46 -05:00
parent 583fda7a70
commit 65107a5624
No known key found for this signature in database
GPG key ID: 656D3395E4A9791A
2 changed files with 13 additions and 42 deletions
Download patch file Download diff file Expand all files Collapse all files

13
tests/unit/test_decision_engine.py
View file

@ -118,12 +118,12 @@ def test_was_selected_excludes_errors(select_list, error_code):
(defaults.SELECT, defaults.IGNORE, 'E126', style_guide.Decision.Ignored),
(defaults.SELECT, defaults.IGNORE, 'W391', style_guide.Decision.Selected),
])
def test_should_report_error(select_list, ignore_list, error_code, expected):
def test_decision_for(select_list, ignore_list, error_code, expected):
"""Verify we decide when to report an error."""
decider = style_guide.DecisionEngine(create_options(select=select_list,
ignore=ignore_list))
assert decider.should_report_error(error_code) is expected
assert decider.decision_for(error_code) is expected
@pytest.mark.parametrize(
@ -164,9 +164,10 @@ def test_should_report_error(select_list, ignore_list, error_code, expected):
style_guide.Decision.Selected),
]
)
def test_decision_for_logic(select, ignore, extend_select, enabled_extensions,
error_code, expected):
"""Verify the complicated logic of DecisionEngine.decision_for."""
def test_more_specific_decision_for_logic(select, ignore, extend_select,
enabled_extensions, error_code,
expected):
"""Verify the logic of DecisionEngine.more_specific_decision_for."""
decider = style_guide.DecisionEngine(
create_options(
select=select, ignore=ignore,
@ -175,4 +176,4 @@ def test_decision_for_logic(select, ignore, extend_select, enabled_extensions,
),
)
assert decider.decision_for(error_code) is expected
assert decider.more_specific_decision_for(error_code) is expected