From 585628875d29f4a46d8adbccc0e1bfa7b3a4a347 Mon Sep 17 00:00:00 2001 From: Ian Cordasco Date: Sat, 27 Aug 2016 19:53:14 -0500 Subject: [PATCH] Ensure column_number is always an integer When a SyntaxError is raised, column_number may be None. Unfortunately, it's not obvious where that None comes from so we must handle it in handle_error. Closes #214 --- src/flake8/style_guide.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/flake8/style_guide.py b/src/flake8/style_guide.py index a1ab473..4d8950c 100644 --- a/src/flake8/style_guide.py +++ b/src/flake8/style_guide.py @@ -253,7 +253,10 @@ class StyleGuide(object): int """ # NOTE(sigmavirus24): Apparently we're provided with 0-indexed column - # numbers so we have to offset that here. + # numbers so we have to offset that here. Also, if a SyntaxError is + # caught, column_number may be None. + if not column_number: + column_number = 0 error = Error(code, filename, line_number, column_number + 1, text, physical_line) error_is_selected = (self.should_report_error(error.code) is