pre-commit/flake8
1
0
Fork 0
mirror of https://github.com/PyCQA/flake8.git synced 2026-04-25 04:44:31 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Hoist passing through sys.argv at the CLI layer

Browse source 
`flake8.main.cli.main()` is the primary entry point for the command-line
implementation of flake8 (invoked via `__main__` or `console_scripts`).
Therefore, it is reasonable for the entry point to be responsible for
obtaining command line arguments from `sys.argv` there.

Additionally, the contract for various argument parsing methods to be
guaranteed a `List[str]`.
This commit is contained in:
Eric N. Vander Weele 2019-08-28 16:20:38 -04:00
parent 7708e5b4ab
commit 50ac2f7237
3 changed files with 21 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

10
tests/integration/test_main.py
View file

@ -126,3 +126,13 @@ def test_bug_report_successful(capsys):
out, err = capsys.readouterr()
assert json.loads(out)
assert err == ''
def test_obtaining_args_from_sys_argv_when_not_explicity_provided(capsys):
"""Test that arguments are obtained from 'sys.argv'."""
with mock.patch('sys.argv', ['--help']):
_call_main(None)
out, err = capsys.readouterr()
assert out.startswith('usage: flake8 [options] file file ...\n')
assert err == ''