pre-commit/flake8
1
0
Fork 0
mirror of https://github.com/PyCQA/flake8.git synced 2026-04-02 03:46:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Do not run git-hook checks when there are no files

Browse source 
Apparently there are some cases where the git hook will not find files
to run the checks against (e.g., when amending a commit message). In
those cases, it's best not to attempt to run any checks and to allow the
hook to exit successfully.

Closes #303
This commit is contained in:
Ian Cordasco 2017-01-27 15:57:23 -06:00
parent 77d887f400
commit 49fcbf468d
No known key found for this signature in database
GPG key ID: 656D3395E4A9791A
1 changed files with 10 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

13
src/flake8/main/git.py
View file

@ -45,10 +45,17 @@ def hook(lazy=False, strict=False):
app.initialize(['.'])
app.options.exclude = update_excludes(app.options.exclude, tempdir)
app.options._running_from_vcs = True
app.run_checks(filepaths)
# Apparently there are times when there are no files to check (e.g.,
# when amending a commit). In those cases, let's not try to run checks
# against nothing.
if filepaths:
app.run_checks(filepaths)
# If there were files to check, update their paths and report the errors
if filepaths:
update_paths(app.file_checker_manager, tempdir)
app.report_errors()
update_paths(app.file_checker_manager, tempdir)
app.report_errors()
if strict:
return app.result_count
return 0