pre-commit/flake8
1
0
Fork 0
mirror of https://github.com/PyCQA/flake8.git synced 2026-04-13 16:14:18 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Load plugins of each type idempotently

Browse source 
* Do not pass too many arguments to provide_options or register_options
* Sub-class PluginTypeManager for both Listeners and Formatters
This commit is contained in:
Ian Cordasco 2016-01-16 07:03:37 -06:00
parent 6ef9089eb7
commit 45d470927c
1 changed files with 17 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

25
flake8/plugins/manager.py
View file

@ -164,6 +164,7 @@ class PluginTypeManager(object):
def __init__(self): def __init__(self):
"""Initialize the plugin type's manager.""" """Initialize the plugin type's manager."""
self.manager = PluginManager(self.namespace) self.manager = PluginManager(self.namespace)
self.plugins_loaded = False
@property @property
def names(self): def names(self):
@ -182,20 +183,29 @@ class PluginTypeManager(object):
if (method is not None and if (method is not None and
isinstance(method, collections.Callable)): isinstance(method, collections.Callable)):
return method(optmanager, *args, **kwargs) return method(optmanager, *args, **kwargs)
return generated_function
def load_plugins(self): def load_plugins(self):
def load_plugin(plugin): """Load all plugins of this type that are managed by this manager."""
return plugin.load() if self.plugins_loaded:
return
return list(self.manager.map(load_plugin)) def load_plugin(plugin):
return plugin.load_plugin()
plugins = list(self.manager.map(load_plugin))
# Do not set plugins_loaded if we run into an exception
self.plugins_loaded = True
return plugins
def register_options(self, optmanager): def register_options(self, optmanager):
"""Register all of the checkers' options to the OptionManager.""" """Register all of the checkers' options to the OptionManager."""
self.load_plugins()
call_register_options = self._generate_call_function( call_register_options = self._generate_call_function(
'register_options', optmanager, 'register_options', optmanager,
) )
list(self.manager.map(call_register_options, optmanager)) list(self.manager.map(call_register_options))
def provide_options(self, optmanager, options, extra_args): def provide_options(self, optmanager, options, extra_args):
"""Provide parsed options and extra arguments to the plugins.""" """Provide parsed options and extra arguments to the plugins."""
@ -203,8 +213,7 @@ class PluginTypeManager(object):
'provide_options', optmanager, options, extra_args, 'provide_options', optmanager, options, extra_args,
) )
list(self.manager.map(call_provide_options, optmanager, options, list(self.manager.map(call_provide_options))
extra_args))
class Checkers(PluginTypeManager): class Checkers(PluginTypeManager):
@ -213,13 +222,13 @@ class Checkers(PluginTypeManager):
namespace = 'flake8.extension' namespace = 'flake8.extension'
class Listeners(object): class Listeners(PluginTypeManager):
"""All of the listeners registered through entry-points.""" """All of the listeners registered through entry-points."""
namespace = 'flake8.listen' namespace = 'flake8.listen'
class ReportFormatters(object): class ReportFormatters(PluginTypeManager):
"""All of the report formatters registered through entry-points.""" """All of the report formatters registered through entry-points."""
namespace = 'flake8.report' namespace = 'flake8.report'