pre-commit/flake8
1
0
Fork 0
mirror of https://github.com/PyCQA/flake8.git synced 2026-04-16 17:19:52 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Generate dest for Options always

Browse source
This commit is contained in:
Ian Cordasco 2016-01-09 15:32:44 -06:00
parent 09bc9e2720
commit 36cc254542
2 changed files with 8 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

9
flake8/options/manager.py
View file

@ -72,7 +72,7 @@ class Option(object):
'action': action, 'action': action,
'default': default, 'default': default,
'type': type, 'type': type,
'dest': dest, 'dest': self._make_dest(dest),
'callback': callback, 'callback': callback,
'callback_args': callback_args, 'callback_args': callback_args,
'callback_kwargs': callback_kwargs, 'callback_kwargs': callback_kwargs,
@ -93,7 +93,7 @@ class Option(object):
if not long_option_name: if not long_option_name:
raise ValueError('When specifying parse_from_config=True, ' raise ValueError('When specifying parse_from_config=True, '
'a long_option_name must also be specified.') 'a long_option_name must also be specified.')
self.config_name = long_option_name.strip('-').replace('-', '_') self.config_name = self.dest
def __repr__(self): def __repr__(self):
return ( return (
@ -103,6 +103,11 @@ class Option(object):
'callback_kwargs={callback_kwargs}, metavar={metavar})' 'callback_kwargs={callback_kwargs}, metavar={metavar})'
).format(*self.option_args, **self.option_kwargs) ).format(*self.option_args, **self.option_kwargs)
def _make_dest(self, dest):
if self.long_option_name:
return self.long_option_name[2:].replace('-', '_')
return self.short_option_name[1]
def to_optparse(self): def to_optparse(self):
"""Convert a Flake8 Option to an optparse Option.""" """Convert a Flake8 Option to an optparse Option."""
if not hasattr(self, '_opt'): if not hasattr(self, '_opt'):

2
tests/unit/test_option.py
View file

@ -32,7 +32,7 @@ def test_to_optparse_creates_an_option_as_we_expect(Option):
'action': 'count', 'action': 'count',
'default': None, 'default': None,
'type': None, 'type': None,
'dest': None, 'dest': 'test',
'callback': None, 'callback': None,
'callback_args': None, 'callback_args': None,
'callback_kwargs': None, 'callback_kwargs': None,