mirror of
https://github.com/PyCQA/flake8.git
synced 2026-03-29 18:46:52 +00:00
Parse hyphenated config names also
Previously Flake8 parsed both
max-line-length = 110
And
max_line_length = 110
From the config file without issue. When we updated our logic, I forgot
to test for that and we lost that behaviour temporarily.
Closes #152
This commit is contained in:
parent
95c373cf11
commit
31c32e3327
4 changed files with 37 additions and 2 deletions
|
|
@ -192,7 +192,7 @@ class MergedConfigParser(object):
|
|||
LOG.debug('Option "%s" returned value: %r', option_name, value)
|
||||
|
||||
final_value = self._normalize_value(option, value)
|
||||
config_dict[option_name] = final_value
|
||||
config_dict[option.config_name] = final_value
|
||||
|
||||
return config_dict
|
||||
|
||||
|
|
|
|||
|
|
@ -186,7 +186,9 @@ class OptionManager(object):
|
|||
self.parser.add_option(option.to_optparse())
|
||||
self.options.append(option)
|
||||
if option.parse_from_config:
|
||||
self.config_options_dict[option.config_name] = option
|
||||
name = option.config_name
|
||||
self.config_options_dict[name] = option
|
||||
self.config_options_dict[name.replace('_', '-')] = option
|
||||
LOG.debug('Registered option "%s".', option)
|
||||
|
||||
def remove_from_default_ignore(self, error_codes):
|
||||
|
|
|
|||
5
tests/fixtures/config_files/config-with-hyphenated-options.ini
vendored
Normal file
5
tests/fixtures/config_files/config-with-hyphenated-options.ini
vendored
Normal file
|
|
@ -0,0 +1,5 @@
|
|||
[flake8]
|
||||
max-line-length = 110
|
||||
enable_extensions =
|
||||
H101,
|
||||
H235
|
||||
|
|
@ -204,3 +204,31 @@ def test_parsed_configs_are_equivalent(optmanager, config_fixture_path):
|
|||
os.path.abspath('bar/'),
|
||||
os.path.abspath('bogus/'),
|
||||
]
|
||||
|
||||
|
||||
@pytest.mark.parametrize('config_file', [
|
||||
'tests/fixtures/config_files/config-with-hyphenated-options.ini'
|
||||
])
|
||||
def test_parsed_hyphenated_and_underscored_names(optmanager, config_file):
|
||||
"""Verify we find hyphenated option names as well as underscored.
|
||||
|
||||
This tests for options like --max-line-length and --enable-extensions
|
||||
which are able to be specified either as max-line-length or
|
||||
max_line_length in our config files.
|
||||
"""
|
||||
optmanager.add_option('--max-line-length', parse_from_config=True,
|
||||
type='int')
|
||||
optmanager.add_option('--enable-extensions', parse_from_config=True,
|
||||
comma_separated_list=True)
|
||||
parser = config.MergedConfigParser(optmanager)
|
||||
config_finder = parser.config_finder
|
||||
|
||||
with mock.patch.object(config_finder, 'local_config_files') as localcfs:
|
||||
localcfs.return_value = [config_file]
|
||||
with mock.patch.object(config_finder,
|
||||
'user_config_file') as usercf:
|
||||
usercf.return_value = []
|
||||
parsed_config = parser.merge_user_and_local_config()
|
||||
|
||||
assert parsed_config['max_line_length'] == 110
|
||||
assert parsed_config['enable_extensions'] == ['H101', 'H235']
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue