mirror of
https://github.com/PyCQA/flake8.git
synced 2026-04-09 22:34:17 +00:00
Allow noqa to apply to lines due to continuation
This commit is contained in:
parent
8f9b4931b9
commit
28797a57d8
5 changed files with 122 additions and 30 deletions
|
|
@ -15,7 +15,7 @@ EXPECTED_RESULT_PHYSICAL_LINE = (
|
|||
0,
|
||||
1,
|
||||
'Expected Message',
|
||||
PHYSICAL_LINE,
|
||||
None,
|
||||
)
|
||||
|
||||
|
||||
|
|
@ -153,11 +153,10 @@ def test_line_check_results(plugin_target, len_results):
|
|||
"""Test the FileChecker class handling results from line checks."""
|
||||
file_checker = mock_file_checker_with_plugin(plugin_target)
|
||||
|
||||
# Results will be store in an internal array
|
||||
# Results will be stored in an internal array
|
||||
file_checker.run_physical_checks(PHYSICAL_LINE)
|
||||
assert file_checker.results == [
|
||||
EXPECTED_RESULT_PHYSICAL_LINE
|
||||
] * len_results
|
||||
expected = [EXPECTED_RESULT_PHYSICAL_LINE] * len_results
|
||||
assert file_checker.results == expected
|
||||
|
||||
|
||||
PLACEHOLDER_CODE = 'some_line = "of" * code'
|
||||
|
|
|
|||
|
|
@ -182,6 +182,25 @@ t.py:1:15: E711 comparison to None should be 'if cond is None:'
|
|||
'''
|
||||
|
||||
|
||||
def test_specific_noqa_on_line_with_continuation(tmpdir, capsys):
|
||||
"""See https://gitlab.com/pycqa/flake8/issues/375."""
|
||||
t_py_src = '''\
|
||||
from os \\
|
||||
import path # noqa: F401
|
||||
|
||||
x = """
|
||||
trailing whitespace: \n
|
||||
""" # noqa: W291
|
||||
'''
|
||||
|
||||
with tmpdir.as_cwd():
|
||||
tmpdir.join('t.py').write(t_py_src)
|
||||
_call_main(['t.py'], retv=0)
|
||||
|
||||
out, err = capsys.readouterr()
|
||||
assert out == err == ''
|
||||
|
||||
|
||||
def test_obtaining_args_from_sys_argv_when_not_explicity_provided(capsys):
|
||||
"""Test that arguments are obtained from 'sys.argv'."""
|
||||
with mock.patch('sys.argv', ['flake8', '--help']):
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue