pre-commit/flake8
1
0
Fork 0
mirror of https://github.com/PyCQA/flake8.git synced 2026-04-01 11:26:54 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

checker: allow physical checks to return multiple results, add tests

Browse source
This commit is contained in:
Tom Milligan 2018-12-05 22:04:32 +00:00 • committed by Tom Milligan
parent 93ad9617b0
commit 2803d0a810
No known key found for this signature in database
GPG key ID: BFF10895C45328D2
2 changed files with 109 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

39
src/flake8/checker.py
View file

@ -541,21 +541,38 @@ class FileChecker(object):
self.processor.next_logical_line()
def run_physical_checks(self, physical_line, override_error_line=None):
"""Run all checks for a given physical line."""
"""Run all checks for a given physical line.
A single physical check may return multiple errors.
"""
for plugin in self.checks["physical_line_plugins"]:
self.processor.update_checker_state_for(plugin)
result = self.run_check(plugin, physical_line=physical_line)
if result is not None:
column_offset, text = result
error_code = self.report(
error_code=None,
line_number=self.processor.line_number,
column=column_offset,
text=text,
line=(override_error_line or physical_line),
)
self.processor.check_physical_error(error_code, physical_line)
if result is not None:
# This is a single result if first element is an int
column_offset = None
try:
column_offset = result[0]
except (IndexError, TypeError):
pass
if isinstance(column_offset, int):
# If we only have a single result, convert to a collection
result = (result,)
for result_single in result:
column_offset, text = result_single
error_code = self.report(
error_code=None,
line_number=self.processor.line_number,
column=column_offset,
text=text,
line=(override_error_line or physical_line),
)
self.processor.check_physical_error(
error_code, physical_line
)
def process_tokens(self):
"""Process tokens and trigger checks.