pre-commit/flake8
1
0
Fork 0
mirror of https://github.com/PyCQA/flake8.git synced 2026-04-05 12:36:54 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Reset Application.formatter attribute in init_report

Browse source 
For our Legacy API users, StyleGuide.init_report should reset the
formatter attribute before calling Application.make_formatter().

Closes #200
This commit is contained in:
Ian Cordasco 2016-07-30 06:42:34 -05:00
parent b02855769b
commit 22650e5086
No known key found for this signature in database
GPG key ID: 656D3395E4A9791A
2 changed files with 6 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

5
docs/source/release-notes/3.0.3.rst
View file

@ -23,6 +23,9 @@
- Fix issue where users were unable to ignore plugin errors that were on - Fix issue where users were unable to ignore plugin errors that were on
by default. (See also `GitLab#195`_) by default. (See also `GitLab#195`_)
- Fix our legacy API StyleGuide's ``init_report`` method to actually override
the previous formatter. (See also `GitLab#200`_)
.. links .. links
.. _GitLab#164: .. _GitLab#164:
@ -35,5 +38,7 @@
https://gitlab.com/pycqa/flake8/issues/193 https://gitlab.com/pycqa/flake8/issues/193
.. _GitLab#195: .. _GitLab#195:
https://gitlab.com/pycqa/flake8/issues/195 https://gitlab.com/pycqa/flake8/issues/195
.. _GitLab#200:
https://gitlab.com/pycqa/flake8/issues/200
.. _this Python bug report: .. _this Python bug report:
https://bugs.python.org/issue27649 https://bugs.python.org/issue27649

1
src/flake8/api/legacy.py
View file

@ -120,6 +120,7 @@ class StyleGuide(object):
if not issubclass(reporter, formatter.BaseFormatter): if not issubclass(reporter, formatter.BaseFormatter):
raise ValueError("Report should be subclass of " raise ValueError("Report should be subclass of "
"flake8.formatter.BaseFormatter.") "flake8.formatter.BaseFormatter.")
self._application.formatter = None
self._application.make_formatter(reporter) self._application.make_formatter(reporter)
self._application.guide = None self._application.guide = None
# NOTE(sigmavirus24): This isn't the intended use of # NOTE(sigmavirus24): This isn't the intended use of