pre-commit/flake8
1
0
Fork 0
mirror of https://github.com/PyCQA/flake8.git synced 2026-04-09 06:14:17 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Remove unused 'cli_config' parameter

Browse source 
Now that `ConfigFileFinder.config_file` attribute is used everywhere and
is constructed from the `--config` CLI option, the now unused
`cli_config` parameters can be safely removed.
This commit is contained in:
Eric N. Vander Weele 2020-01-12 15:33:54 -08:00
parent 77b2506071
commit 1e3bad20dd
8 changed files with 19 additions and 35 deletions
Download patch file Download diff file Expand all files Collapse all files

2
tests/unit/test_get_local_plugins.py
View file

@ -27,7 +27,7 @@ def test_get_local_plugins_uses_cli_config():
config_file_value = 'foo.ini'
config_finder.config_file = config_file_value
config.get_local_plugins(config_finder, cli_config=config_file_value)
config.get_local_plugins(config_finder)
config_finder.cli_config.assert_called_once_with(config_file_value)

4
tests/unit/test_legacy_api.py
View file

@ -31,10 +31,10 @@ def test_get_style_guide():
application.assert_called_once_with()
mockedapp.parse_preliminary_options.assert_called_once_with([])
mockedapp.find_plugins.assert_called_once_with(config_finder, None)
mockedapp.find_plugins.assert_called_once_with(config_finder)
mockedapp.register_plugin_options.assert_called_once_with()
mockedapp.parse_configuration_and_cli.assert_called_once_with(
config_finder, None, [])
config_finder, [])
mockedapp.make_formatter.assert_called_once_with()
mockedapp.make_guide.assert_called_once_with()
mockedapp.make_file_checker_manager.assert_called_once_with()

2
tests/unit/test_merged_config_parser.py
View file

@ -161,7 +161,7 @@ def test_parse_uses_cli_config(optmanager):
config_finder.ignore_config_files = False
parser = config.MergedConfigParser(optmanager, config_finder)
parser.parse(cli_config=config_file_value)
parser.parse()
config_finder.cli_config.assert_called_once_with(config_file_value)