pre-commit/flake8
1
0
Fork 0
mirror of https://github.com/PyCQA/flake8.git synced 2026-04-08 14:04:16 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Actually remove enabled extensions from ignore list

Browse source 
When we enable a plugin (when it's provided in the --enable-extensions)
plugin, we need to remove it both from the extended default ignore list
and the plain ignore list.

Closes #239
This commit is contained in:
Ian Cordasco 2016-11-09 18:43:42 -06:00
parent ca4f631fb2
commit 1dfd6bae77
No known key found for this signature in database
GPG key ID: 656D3395E4A9791A
2 changed files with 34 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

11
src/flake8/plugins/manager.py
View file

@ -182,10 +182,17 @@ class Plugin(object):
LOG.critical(str(failed_to_load))
raise failed_to_load
def enable(self, optmanager):
def enable(self, optmanager, options=None):
"""Remove plugin name from the default ignore list."""
optmanager.remove_from_default_ignore([self.name])
optmanager.extend_default_select([self.name])
if not options:
return
try:
options.ignore.remove(self.name)
except (ValueError, KeyError):
LOG.debug('Attempted to remove %s from the ignore list but it was '
'not a member of the list.', self.name)
def disable(self, optmanager):
"""Add the plugin name to the default ignore list."""
@ -202,7 +209,7 @@ class Plugin(object):
parse_options(options)
if self.name in options.enable_extensions:
self.enable(optmanager)
self.enable(optmanager, options)
def register_options(self, optmanager):
"""Register the plugin's command-line options on the OptionManager.