pre-commit/flake8
1
0
Fork 0
mirror of https://github.com/PyCQA/flake8.git synced 2026-04-06 13:06:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

utils: Change normalize_paths() contract

Browse source 
The `normalize_paths()` utility was doing too much — parsing
unstructured configuration path data and dispatching the scrubbed paths
to be normalized.

Towards moving the parsing of unstructured configuration path data
closer towards were configuration occurs, have the utility accept only
structured input for normalizing paths.
This commit is contained in:
Eric N. Vander Weele 2019-07-28 10:39:27 -04:00
parent a0cd55fd6d
commit 1ba56b9056
3 changed files with 9 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

7
tests/unit/test_utils.py
View file

@ -127,14 +127,13 @@ def test_normalize_path(value, expected):
@pytest.mark.parametrize("value,expected", [
("flake8,pep8,pyflakes,mccabe", ["flake8", "pep8", "pyflakes", "mccabe"]),
("flake8,\n\tpep8,\n pyflakes,\n\n mccabe",
(["flake8", "pep8", "pyflakes", "mccabe"],
["flake8", "pep8", "pyflakes", "mccabe"]),
("../flake8,../pep8,../pyflakes,../mccabe",
(["../flake8", "../pep8", "../pyflakes", "../mccabe"],
[os.path.abspath("../" + p) for p in RELATIVE_PATHS]),
])
def test_normalize_paths(value, expected):
"""Verify we normalize comma-separated paths provided to the tool."""
"""Verify we normalizes a sequence of paths provided to the tool."""
assert utils.normalize_paths(value) == expected