pre-commit/flake8
1
0
Fork 0
mirror of https://github.com/PyCQA/flake8.git synced 2026-04-06 04:56:54 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor plugin loading options to prepare for --require-plugins

Browse source
This commit is contained in:
Anthony Sottile 2022-01-10 20:03:25 -05:00
parent 6abefff89e
commit 1b58293ad3
5 changed files with 59 additions and 29 deletions
Download patch file Download diff file Expand all files Collapse all files

3
tests/integration/test_checker.py
View file

@ -90,7 +90,8 @@ def mock_file_checker_with_plugin(plugin_target):
),
),
]
plugins = finder.load_plugins(to_load, [], set())
opts = finder.PluginOptions(frozenset())
plugins = finder.load_plugins(to_load, [], opts)
# Prevent it from reading lines from stdin or somewhere else
with mock.patch(

7
tests/integration/test_plugins.py
View file

@ -55,7 +55,8 @@ def test_enable_local_plugin_from_config(local_config):
cfg, cfg_dir = config.load_config(local_config, [], isolated=False)
plugins = finder.find_plugins(cfg)
plugin_paths = finder.find_local_plugin_paths(cfg, cfg_dir)
loaded_plugins = finder.load_plugins(plugins, plugin_paths, set())
opts = finder.PluginOptions(frozenset())
loaded_plugins = finder.load_plugins(plugins, plugin_paths, opts)
(custom_extension,) = (
loaded
@ -82,8 +83,8 @@ def test_local_plugin_can_add_option(local_config):
plugins = finder.find_plugins(cfg)
plugin_paths = finder.find_local_plugin_paths(cfg, cfg_dir)
enabled = finder.parse_enabled(cfg, stage1_args.enable_extensions)
loaded_plugins = finder.load_plugins(plugins, plugin_paths, enabled)
opts = finder.PluginOptions(frozenset())
loaded_plugins = finder.load_plugins(plugins, plugin_paths, opts)
option_manager = OptionManager(
version="123",

23
tests/unit/plugins/finder_test.py
View file

@ -376,15 +376,18 @@ def test_find_local_plugins(local_plugin_cfg):
}
def test_parse_enabled_not_specified():
assert finder.parse_enabled(configparser.RawConfigParser(), None) == set()
def test_parse_plugin_options_not_specified():
cfg = configparser.RawConfigParser()
ret = finder.parse_plugin_options(cfg, None)
assert ret == finder.PluginOptions(frozenset())
def test_parse_enabled_from_commandline():
cfg = configparser.RawConfigParser()
cfg.add_section("flake8")
cfg.set("flake8", "enable_extensions", "A,B,C")
assert finder.parse_enabled(cfg, "D,E,F") == {"D", "E", "F"}
ret = finder.parse_plugin_options(cfg, "D,E,F")
assert ret == finder.PluginOptions(frozenset(("D", "E", "F")))
@pytest.mark.parametrize("opt", ("enable_extensions", "enable-extensions"))
@ -392,7 +395,8 @@ def test_parse_enabled_from_config(opt):
cfg = configparser.RawConfigParser()
cfg.add_section("flake8")
cfg.set("flake8", opt, "A,B,C")
assert finder.parse_enabled(cfg, None) == {"A", "B", "C"}
ret = finder.parse_plugin_options(cfg, None)
assert ret == finder.PluginOptions(frozenset(("A", "B", "C")))
def test_find_plugins(
@ -600,7 +604,7 @@ def test_classify_plugins():
logical_line_plugin,
physical_line_plugin,
],
set(),
finder.PluginOptions(frozenset()),
)
assert classified == finder.Plugins(
@ -619,8 +623,10 @@ def test_classify_plugins_enable_a_disabled_plugin():
plugin = _plugin(ep=_ep(name="ABC"))
loaded = _loaded(plugin=plugin, parameters={"tree": True}, obj=obj)
classified_normal = finder._classify_plugins([loaded], set())
classified_enabled = finder._classify_plugins([loaded], {"ABC"})
normal_opts = finder.PluginOptions(frozenset())
classified_normal = finder._classify_plugins([loaded], normal_opts)
enabled_opts = finder.PluginOptions(frozenset(("ABC",)))
classified_enabled = finder._classify_plugins([loaded], enabled_opts)
assert classified_normal == finder.Plugins(
checkers=finder.Checkers([], [], []),
@ -638,7 +644,8 @@ def test_classify_plugins_enable_a_disabled_plugin():
def test_load_plugins():
plugin = _plugin(ep=_ep(value="aplugin:ExtensionTestPlugin2"))
ret = finder.load_plugins([plugin], ["tests/integration/subdir"], set())
opts = finder.PluginOptions(frozenset())
ret = finder.load_plugins([plugin], ["tests/integration/subdir"], opts)
import aplugin