pre-commit/flake8
1
0
Fork 0
mirror of https://github.com/PyCQA/flake8.git synced 2026-04-05 04:36:52 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

application: Rename prelim parsing method to 'parse_preliminary_options'

Browse source 
Positional arguments are not used nor parsed for pre-configuration
loading.  Thus, renaming the method and updating the docstrings
appropriately.
This commit is contained in:
Eric N. Vander Weele 2019-11-01 22:19:15 -04:00
parent b5157e194d
commit 1abe1d42c2
4 changed files with 11 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

9
tests/unit/test_application.py
View file

@ -92,7 +92,7 @@ def test_returns_specified_plugin(application):
def test_prelim_opts_args(application):
"""Verify we get sensible prelim opts and args."""
opts, args = application.parse_preliminary_options_and_args(
opts, args = application.parse_preliminary_options(
['--foo', '--verbose', 'src', 'setup.py', '--statistics', '--version'])
assert opts.verbose
@ -104,10 +104,7 @@ def test_prelim_opts_ignore_help(application):
# GIVEN
# WHEN
_, args = application.parse_preliminary_options_and_args([
'--help',
'-h',
])
_, args = application.parse_preliminary_options(['--help', '-h'])
# THEN
assert args == ['--help', '-h']
@ -117,6 +114,6 @@ def test_prelim_opts_handles_empty(application):
"""Verify empty argv lists are handled correctly."""
irrelevant_args = ['myexe', '/path/to/foo']
with mock.patch.object(sys, 'argv', irrelevant_args):
opts, args = application.parse_preliminary_options_and_args([])
opts, args = application.parse_preliminary_options([])
assert args == []

7
tests/unit/test_legacy_api.py
View file

@ -18,16 +18,13 @@ def test_get_style_guide():
verbose=0,
)
mockedapp = mock.Mock()
mockedapp.parse_preliminary_options_and_args.return_value = (
prelim_opts,
[],
)
mockedapp.parse_preliminary_options.return_value = (prelim_opts, [])
with mock.patch('flake8.main.application.Application') as application:
application.return_value = mockedapp
style_guide = api.get_style_guide()
application.assert_called_once_with()
mockedapp.parse_preliminary_options_and_args.assert_called_once_with([])
mockedapp.parse_preliminary_options.assert_called_once_with([])
mockedapp.make_config_finder.assert_called_once_with([])
mockedapp.find_plugins.assert_called_once_with(None, False)
mockedapp.register_plugin_options.assert_called_once_with()