pre-commit/flake8
1
0
Fork 0
mirror of https://github.com/PyCQA/flake8.git synced 2026-04-07 05:26:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

FileProcessor.keyword_arguments_for: Optimize by removing arguments.

Browse source 
Attaching the extra arguments directly to the FileProcessor object
lets us streamline this code for a 6% speedup.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
This commit is contained in:
Anders Kaseorg 2020-05-13 02:20:22 -07:00
parent 2529983e5c
commit 0bb9e453c7
3 changed files with 25 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

10
tests/unit/test_file_processor.py
View file

@ -188,7 +188,7 @@ def test_next_line(default_options):
@pytest.mark.parametrize('params, args, expected_kwargs', [
({'blank_before': True, 'blank_lines': True},
None,
{},
{'blank_before': 0, 'blank_lines': 0}),
({'noqa': True, 'fake': True},
{'fake': 'foo'},
@ -196,8 +196,8 @@ def test_next_line(default_options):
({'blank_before': True, 'blank_lines': True, 'noqa': True},
{'blank_before': 10, 'blank_lines': 5, 'noqa': True},
{'blank_before': 10, 'blank_lines': 5, 'noqa': True}),
({}, {'fake': 'foo'}, {'fake': 'foo'}),
({'non-existent': False}, {'fake': 'foo'}, {'fake': 'foo'}),
({'fake': False}, {'fake': 'foo'}, {'fake': 'foo'}),
({'fake': False, 'non-existent': False}, {'fake': 'foo'}, {'fake': 'foo'}),
])
def test_keyword_arguments_for(params, args, expected_kwargs, default_options):
"""Verify the keyword args are generated properly."""
@ -206,7 +206,9 @@ def test_keyword_arguments_for(params, args, expected_kwargs, default_options):
])
kwargs_for = file_processor.keyword_arguments_for
assert kwargs_for(params, args) == expected_kwargs
for k, v in args.items():
setattr(file_processor, k, v)
assert kwargs_for(params) == expected_kwargs
def test_keyword_arguments_for_does_not_handle_attribute_errors(